Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUN-439: Replace react-native-camera #873

Open
jira-to-github-migrator bot opened this issue Aug 13, 2023 · 4 comments · May be fixed by #1034
Open

LUN-439: Replace react-native-camera #873

jira-to-github-migrator bot opened this issue Aug 13, 2023 · 4 comments · May be fixed by #1034
Assignees

Comments

@jira-to-github-migrator
Copy link

Stefanie Metzger - 26.9.2022, 11:58:44

react-native-camera is now deprecated.
Since we use https://github.com/ivpusic/react-native-image-crop-picker for selecting image from gallery it would make sense to use it also for camera

 

Maybe we should update as well, not really urgent. 

Also remove the patch for it.

 

Maybe this would be the best chioce: https://github.com/mrousavy/react-native-vision-camera

 

Also see comments

 

Note for testing: Nothing should change in camera behaviour.

Environment: -
Linked issues:

  • Blocks: LUN-440
@jira-to-github-migrator
Copy link
Author

lunars97 - 24.4.2023, 11:00:40

<~stefanie.metzger> seems like react-native-image-crop-picker does not have built-in bar-code scanner feature

lunars97 - 24.4.2023, 13:07:21

Maybe we can replace entirely with https://github.com/mrousavy/react-native-vision-camera

Stefanie Metzger - 25.4.2023, 13:15:43

Seems a good choice to me, I think we need to use two libraries if we want to pick from gallery and read QR-Codes, as I think there is no good library supporting both. Let's discuss this in the grooming, as I see a high risk the PR is rejected, because there are other ideas which library would be the best fit.

lunars97 - 25.4.2023, 14:20:19

if we want to implement react-native-image crop-picker then we can also consider https://www.npmjs.com/package/react-native-qrcode-scanner  so that we can combine these two

@sarahsporck
Copy link
Contributor

react-native-qrcode-scanner also hasn't been updated for 2 years. I'd tend to use react-native-vision-camera. Especially as the new version seems to be very performant and react-native 0.72 conform. The only argument against it is that the implemented barcode scanners all rely on googles mlkit, and are therefore not really open source. @SteffiStuffel would that be a problem? We could also try to spend some time to implement barcode scanning with zxing.

@ztefanie
Copy link
Member

ztefanie commented Sep 13, 2023

@sarahsporck Fine for me.

@ztefanie
Copy link
Member

Decision from grooming: We wait for react-native-vision-camera to become stable in the current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

3 participants