Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add popup for information about page access statistics [Wait for #3130] #3231

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Add popup for information about page access statistics [Wait for #3130] #3231

wants to merge 2 commits into from

Conversation

MizukiTemma
Copy link
Member

@MizukiTemma MizukiTemma commented Nov 22, 2024 •
edited by JoeyStk
Loading

Short description

This PR adds an pop-up on the statistics page and shows users hints for better interpretation of statistics.

Proposed changes

  • Reuse the functinality of tutorial pop-up for page tree
  • Show the texts suggested by the service team

Side effects

  • In the design the icon ℹ️ should be placed next to "Page access staistics/Seitenzugriffe" (second box under "Total accesses/Anzahl der Online-Zugriffe") but currently implemented next to the title "Statistics", as the box "Page access statistics" is not yet implemented.

Resolved issues

Fixes: #3132

Pull Request Review Guidelines

@MizukiTemma
Copy link
Member Author

Some hints to "see" the pop up

  • Set statistics_tutorial_seen" to true as it is false in the test data.
  • Or click ℹ️ icon next to the title "Statistics"

@JoeyStk JoeyStk self-assigned this Nov 25, 2024
lunars97
lunars97 reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@lunars97 lunars97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! Everything looks good except for one remark :)

integreat_cms/locale/de/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
@MizukiTemma MizukiTemma force-pushed the feature/page_access_statistics_popup branch 2 times, most recently from 6defceb to 111a052 Compare November 26, 2024 09:30
@MizukiTemma MizukiTemma requested a review from lunars97 November 26, 2024 09:31
lunars97
lunars97 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@lunars97 lunars97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

JoeyStk
JoeyStk requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
This looks already quite good. I think the styling needs a few twist, but then this is good to go 🚀
However I spoke with @osmers and this shouldn't be released before #3130, so it might sense to add the blocked label once this is approved and ready :)

integreat_cms/cms/templates/tutorials/page_access_statistics.html Outdated Show resolved Hide resolved
integreat_cms/cms/templates/tutorials/page_access_statistics.html Outdated Show resolved Hide resolved
integreat_cms/cms/templates/tutorials/page_access_statistics.html Outdated Show resolved Hide resolved
integreat_cms/cms/templates/tutorials/page_access_statistics.html Outdated Show resolved Hide resolved
integreat_cms/locale/de/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
integreat_cms/cms/models/users/user.py Show resolved Hide resolved
integreat_cms/cms/models/users/user.py Show resolved Hide resolved
integreat_cms/release_notes/current/unreleased/3132.yml Outdated Show resolved Hide resolved
@MizukiTemma MizukiTemma added the blocked Blocked by external dependency label Nov 26, 2024
@MizukiTemma MizukiTemma changed the title Add popup for information about page access statistics Add popup for information about page access statistics [Wait for #3130] Nov 26, 2024
@MizukiTemma MizukiTemma force-pushed the feature/page_access_statistics_popup branch from 37e0067 to 2693b5e Compare November 26, 2024 12:44
@MizukiTemma MizukiTemma requested a review from JoeyStk November 26, 2024 12:45
JoeyStk
JoeyStk approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. Looks good! 🚀

@MizukiTemma MizukiTemma marked this pull request as draft November 28, 2024 21:17
@MizukiTemma MizukiTemma marked this pull request as ready for review November 28, 2024 21:17
@MizukiTemma MizukiTemma marked this pull request as draft November 28, 2024 21:17
@MizukiTemma
Copy link
Member Author

Turned into draft to avoid accidental merge. This PR should be first merged after #3130 is done.

@MizukiTemma MizukiTemma mentioned this pull request Dec 5, 2024
Open
@JoeyStk JoeyStk removed their assignment Dec 7, 2024
@MizukiTemma MizukiTemma force-pushed the feature/page_access_statistics_popup branch from 2693b5e to 19f83be Compare December 9, 2024 16:06
@MizukiTemma MizukiTemma force-pushed the feature/page_access_statistics_popup branch from 19f83be to 0f363ea Compare December 12, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunars97 lunars97 lunars97 approved these changes

@JoeyStk JoeyStk JoeyStk approved these changes

Assignees
No one assigned
Labels
blocked Blocked by external dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2024-12-18] Closable popup for information about page access statistics
3 participants
@MizukiTemma @JoeyStk @lunars97