Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename user fields page_tree_tutorial_seen and statistics_tutorial_seen #3271

Open
MizukiTemma opened this issue Dec 5, 2024 · 0 comments
Open

Rename user fields page_tree_tutorial_seen and statistics_tutorial_seen #3271

MizukiTemma opened this issue Dec 5, 2024 · 0 comments
Labels
effort: low Should be doable in <4h enhancement This improves an existing feature good first issue Good for newcomers

Comments

@MizukiTemma
Copy link
Member

MizukiTemma commented Dec 5, 2024 •
edited
Loading

Motivation

The user model currently has a field page_tree_tutorial_seen and statistics_tutorial_seen will be added after #3231.
They save whether the user has seen the tutorial for page tree/page based statistics and checked "Don't show again".

It's suggested to rename them in a more self-explaining way.

Proposed Solution

Rename them to has_seen_page_tree_tutorial and has_seen_statistics_tutorial. Change the help text to "Has seen tutorial for page tree" and "Has seen tutorial for page access statistics".

Alternatives

Leave as it is

User Story

Additional Context

See this comment and this.

Design Requirements

Related Issues
@MizukiTemma MizukiTemma added the enhancement This improves an existing feature label Dec 5, 2024
@MizukiTemma MizukiTemma mentioned this issue Dec 5, 2024
Draft
@MizukiTemma MizukiTemma added effort: low Should be doable in <4h good first issue Good for newcomers labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low Should be doable in <4h enhancement This improves an existing feature good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MizukiTemma