Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug:Navbar issued resolved #50

Closed
wants to merge 2 commits into from
Closed

bug:Navbar issued resolved #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e7714a
bug:Navbar issued resolved
Anureng Mar 17, 2024
ae19b43
prettier issue resolved
Anureng Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/components/bannerSection/bannerSection.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@
font-size: 64px;
font-weight: 900;
font-family: 'Raleway', sans-serif;
}
}
68 changes: 62 additions & 6 deletions src/app/components/navbar/navbar.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
.mobileNavBar {
display: none;
}

.navbar {
display: flex;
justify-content: space-between;
Expand Down Expand Up @@ -67,13 +68,13 @@
display: none;
}

.hamburger div {
/* .hamburger div {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why are we commenting out code that is not being used. Should be removed.

width: 25px;
height: 3px;
background-color: #3c3db9;
margin: 5px;
transition: all 0.3s ease;
}
} */

.navLinks {
display: flex;
Expand All @@ -89,39 +90,45 @@
display: none;
}
}

@media (max-width: 768px) {
.logo {
display: none;
}

.mobileNavBar {
display: flex;
justify-content: space-between;
align-items: center;
padding: 0 20px;
font-family: 'Raleway', sans-serif;
}

.hamburger {
display: flex;
flex-direction: column;
cursor: pointer;
}

.hamburger div {
/* .hamburger div {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why are we commenting out code that is not being used. Should be removed.

width: 25px;
height: 3px;
background-color: #3c3db9;
margin: 5px;
transition: all 0.3s ease;
}
} */

.mobileNav {
display: flex;
flex-direction: column;
text-decoration: none;
}

.mobileLinks {
font-weight: 900;
text-decoration: none;
}

.navLinks {
display: none;
flex-direction: column;
Expand All @@ -147,15 +154,64 @@
font-size: 25px;
color: #3c3db9;
}

.links::after {
display: none;
}

.meetupLink {
background-color: #fff;
color: #3c3db9;
font-size: 25px;
color: #7444A0;
font-size: 14px;
text-decoration: none;
font-weight: bold;
padding: 0;
}
}

.closeIcon {
width: 30px;
height: 30px;
position: relative;
cursor: pointer;
color: #3c3db9;
}

.closeIcon:before,
.closeIcon:after {
content: '';
position: absolute;
width: 100%;
height: 2px;
background-color: #333;
top: 50%;
left: 0;
color: #3c3db9;
}

.closeIcon:before {
transform: rotate(45deg);
transform-origin: center;
color: #3c3db9;
}

.closeIcon:after {
transform: rotate(-45deg);
transform-origin: center;
color: #3c3db9;
}

/* navbar.module.css */

.line {
width: 25px;
/* Adjust width as needed */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: these comments are not needed. Should be removed.

height: 3px;
/* Adjust height as needed */
background-color: #3c3db9;
/* Adjust color as needed */
margin: 5px;
/* Adjust margin as needed */
transition: all 0.3s ease;
/* Optional: Add transition effect */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: these comments are not needed. Should be removed.

}
28 changes: 19 additions & 9 deletions src/app/components/navbar/navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,23 +37,33 @@ export default function Navbar({ label }: NavbarProps) {
</Link>
</div>
<div className={styles.hamburger} onClick={toggleNav}>
<div className={styles.line}></div>
<div className={styles.line}></div>
<div className={styles.line}></div>
{
isNavVisible ? (
<>
<div className={styles.closeIcon}></div>
</>
) : (
<>
<div className={styles.line}></div>
<div className={styles.line}></div>
<div className={styles.line}></div>
</>
)
}
</div>
<div
className={styles.mobileNavBackground}
style={{ display: isNavVisible ? 'block' : 'none' }}
>
<div className={styles.mobileNav}>
<Link href='/'>
<div className={styles.mobileLinks}>{label.lblCommunity}</div>
<Link className={styles.mobileLinks} href='/'>
{label.lblCommunity}
</Link>
<Link href='/'>
<div className={styles.mobileLinks}>{label.lblContact}</div>
<Link className={styles.mobileLinks} href='/'>
{label.lblContact}
</Link>
<Link href='https://www.meetup.com/dallas-software-developers-meetup/'>
<div className={styles.meetupLink}>{label.lblMeetup}</div>
<Link className={styles.meetupLink} href='https://www.meetup.com/dallas-software-developers-meetup/'>
{label.lblMeetup}
</Link>
</div>
</div>
Expand Down
Loading