Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug:Navbar issued resolved #50

Closed
wants to merge 2 commits into from

Conversation

Anureng
Copy link

@Anureng Anureng commented Mar 17, 2024

No description provided.


.line {
width: 25px;
/* Adjust width as needed */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: these comments are not needed. Should be removed.

margin: 5px;
/* Adjust margin as needed */
transition: all 0.3s ease;
/* Optional: Add transition effect */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: these comments are not needed. Should be removed.

.hamburger {
display: flex;
flex-direction: column;
cursor: pointer;
}

.hamburger div {
/* .hamburger div {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why are we commenting out code that is not being used. Should be removed.

@@ -67,13 +68,13 @@
display: none;
}

.hamburger div {
/* .hamburger div {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why are we commenting out code that is not being used. Should be removed.

@TheDThompsonDev
Copy link
Contributor

Hey @Anureng, I left quite a few comments. These will have to be fixed before the PR can work.

Outside of the comments this is still an issue
image
The font sizes of the links do not match, the color is off as well.

Also if you look here, the menu is very far from the right side of the screen here. It needs to be closer to the side. This is how it is in your PR
image

This is how it was originally
image

Let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants