New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 improvement: Make time property optional #55

Merged

jannikbend merged 16 commits into master from 2-improvement-optional-time-property

Jan 5, 2024

Collaborator

jannikbend commented Dec 2, 2023

No description provided.

jannikbend added 3 commits

December 2, 2023 15:00


          Added entity set without time property to mock server. Refs #2

8a6825b


          Removed not used to and from props. Refs #2

f04ac76


          Removed mandatory time property. Refs #2

06cc7b7

jannikbend linked an issue

that may be closed by this pull request

Improvement: Make time property optional #2

Closed

jannikbend added 3 commits

December 2, 2023 18:10


          Added 'None' to time property selection in query builder. Refs #2

cd34022


          Fixed bug when time prop is selected but not as time property. Refs #2

857a79f


          Added tests for utils. Refs #2

9d69fd0

jannikbend requested a review from carroe

December 6, 2023 19:31


          Added more query tests. Refs #2

e92429e

carroe reviewed

View reviewed changes

pkg/plugin/models.go Show resolved Hide resolved

carroe reviewed

View reviewed changes

pkg/plugin/odata/functions.go Outdated Show resolved Hide resolved

carroe reviewed

View reviewed changes

pkg/plugin/odata/functions.go Outdated Show resolved Hide resolved

carroe added 3 commits

December 8, 2023 22:57


          Fix header and refactor test data generation

8638c0d


          Minor refactoring

f8244d5


          Execute query if only timeProperty is set

d260c47

carroe reviewed

View reviewed changes

pkg/plugin/util.go Outdated Show resolved Hide resolved

carroe reviewed

View reviewed changes

pkg/plugin/util_test.go Outdated Show resolved Hide resolved

carroe marked this pull request as ready for review

December 9, 2023 12:08


          Fix test data model and refactor test data generation

5d3a20a

carroe reviewed

View reviewed changes

pkg/plugin/client.go Outdated Show resolved Hide resolved

carroe reviewed

View reviewed changes

pkg/plugin/client.go Outdated Show resolved Hide resolved

carroe reviewed

View reviewed changes

pkg/plugin/datasource.go Outdated Show resolved Hide resolved

carroe added 2 commits

December 9, 2023 15:34


          Follow Go idomatics

5623af5


          Use https instead of http for all non-localhosts

055afa0

carroe reviewed

View reviewed changes

docker-compose.yaml Show resolved Hide resolved

jannikbend added 2 commits

December 22, 2023 10:12


          Code review changes. Refs #2

7bd83f6


          Removed TODOs. Refs #2

bedbeda

carroe reviewed

View reviewed changes

pkg/plugin/datasource.go Show resolved Hide resolved


          Readded time label, removed labeling TODO. Refs #2

2a70c19

carroe approved these changes

View reviewed changes

jannikbend merged commit 0756189 into master

2 checks passed

carroe deleted the 2-improvement-optional-time-property branch

January 31, 2024 21:17

carroe restored the 2-improvement-optional-time-property branch

January 31, 2024 21:17

carroe deleted the 2-improvement-optional-time-property branch

January 31, 2024 21:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet