Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine Subnet #48

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Redefine Subnet #48

merged 3 commits into from
Aug 6, 2024

Conversation

Columbus240
Copy link
Collaborator

The current definition of Subnet requires (certain forms of) functional extensionality even for simple facts like "every net is a subnet of itself". By restating the definition in an extensional way, such problems/axioms can be avoided.

Also, this PR changes DS_set to be a coercion DirectedSet >-> Sortclass, to simplify various terms. This is analogous to the existing coercion point_set : TopologicalSpace >-> Sortclass.

The previous definition of `Subnet` seems to require (certain forms of)
functional extensionality to prove simple facts like "every net is a
subnet of itself" or the following statement that being a `Subnet` is an
extensional property:
```coq
Lemma Subnet_compat {I J : DirectedSet} {X : Type}
  (x1 x2 : Net I X) (y1 y2 : Net J X) :
  (forall i, x1 i = x2 i) ->
  (forall j, y1 j = y2 j) ->
  Subnet x1 y1 -> Subnet x2 y2.
```

The new definition avoids such difficulties.
The coercion from `DirectedSets` to `Sortclass` makes some code easier
to write.
@Columbus240 Columbus240 merged commit c74949c into master Aug 6, 2024
7 of 8 checks passed
@Columbus240 Columbus240 deleted the Subnet branch August 6, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant