Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More config v6 tests #88

Merged
merged 13 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
environment:
build_version: 9.0.1
build_version: 9.0.2
version: $(build_version)-{build}
image: Visual Studio 2022
configuration: Release
Expand Down
4 changes: 2 additions & 2 deletions src/ConfigCat.Client.Tests/ConfigCacheTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ public async Task ConfigCache_ShouldHandleWhenExternalCacheFails(bool isAsync)
loggerMock.Verify(l => l.Log(LogLevel.Error, 2200, ref It.Ref<FormattableLogMessage>.IsAny, It.Is<Exception>(ex => ex is ApplicationException)), Times.Once);
}

[DataRow("test1", "7f845c43ecc95e202b91e271435935e6d1391e5d")]
[DataRow("test2", "a78b7e323ef543a272c74540387566a22415148a")]
[DataRow("configcat-sdk-1/TEST_KEY-0123456789012/1234567890123456789012", "f83ba5d45bceb4bb704410f51b704fb6dfa19942")]
[DataRow("configcat-sdk-1/TEST_KEY2-123456789012/1234567890123456789012", "da7bfd8662209c8ed3f9db96daed4f8d91ba5876")]
[DataTestMethod]
public void CacheKeyGeneration_ShouldBePlatformIndependent(string sdkKey, string expectedCacheKey)
{
Expand Down
186 changes: 186 additions & 0 deletions src/ConfigCat.Client.Tests/ConfigV2EvaluationTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -586,4 +586,190 @@ public void UserObjectAttributeValueConversion_NonTextComparisons_Test(string sd

Assert.AreEqual(expectedReturnValue, evaluationDetails.Value);
}

[DataTestMethod]
[DataRow("numberToStringConversion", .12345, "1")]
[DataRow("numberToStringConversion", "decimal:0.12345", "1")]
[DataRow("numberToStringConversionInt", (sbyte)125, "4")]
[DataRow("numberToStringConversionInt", (byte)125, "4")]
[DataRow("numberToStringConversionInt", (short)125, "4")]
[DataRow("numberToStringConversionInt", (ushort)125, "4")]
[DataRow("numberToStringConversionInt", 125, "4")]
[DataRow("numberToStringConversionInt", 125u, "4")]
[DataRow("numberToStringConversionInt", 125L, "4")]
[DataRow("numberToStringConversionInt", 125ul, "4")]
[DataRow("numberToStringConversionPositiveExp", -1.23456789e96, "2")]
[DataRow("numberToStringConversionNegativeExp", -12345.6789E-100, "4")]
[DataRow("numberToStringConversionNaN", double.NaN, "3")]
[DataRow("numberToStringConversionPositiveInf", double.PositiveInfinity, "4")]
[DataRow("numberToStringConversionNegativeInf", double.NegativeInfinity, "3")]
[DataRow("dateToStringConversion", "datetime:2023-03-31T23:59:59.9990000Z", "3")]
[DataRow("dateToStringConversion", "datetimeoffset:2023-03-31T23:59:59.9990000Z", "3")]
[DataRow("dateToStringConversion", 1680307199.999, "3")]
[DataRow("dateToStringConversion", "decimal:1680307199.999", "3")]
[DataRow("dateToStringConversionNaN", double.NaN, "3")]
[DataRow("dateToStringConversionPositiveInf", double.PositiveInfinity, "1")]
[DataRow("dateToStringConversionNegativeInf", double.NegativeInfinity, "5")]
[DataRow("stringArrayToStringConversion", new[] { "read", "Write", " eXecute " }, "4")]
[DataRow("stringArrayToStringConversionEmpty", new string[0], "5")]
[DataRow("stringArrayToStringConversionSpecialChars", new[] { "+<>%\"'\\/\t\r\n" }, "3")]
[DataRow("stringArrayToStringConversionUnicode", new[] { "äöüÄÖÜçéèñışğ⢙✓😀" }, "2")]
public void ComparisonAttributeConversionToCanonicalStringRepresentation_Test(string key, object customAttributeValue, string expectedReturnValue)
{
var config = new ConfigLocation.LocalFile("data", "comparison_attribute_conversion.json").FetchConfig();

var logger = new Mock<IConfigCatLogger>().Object.AsWrapper();
var evaluator = new RolloutEvaluator(logger);

if (customAttributeValue is string s)
{
const string decimalPrefix = "decimal:", dateTimePrefix = "datetime:", dateTimeOffsetPrefix = "datetimeoffset:";
if (s.StartsWith(decimalPrefix, StringComparison.Ordinal))
{
customAttributeValue = decimal.Parse(s.Substring(decimalPrefix.Length));
}
else if (s.StartsWith(dateTimePrefix, StringComparison.Ordinal))
{
var dateTimeStyle = s.EndsWith("Z", StringComparison.Ordinal) ? DateTimeStyles.AdjustToUniversal : DateTimeStyles.None;
customAttributeValue = DateTime.ParseExact(s.Substring(dateTimePrefix.Length), "o", CultureInfo.InvariantCulture, dateTimeStyle);
}
else if (s.StartsWith(dateTimeOffsetPrefix, StringComparison.Ordinal))
{
customAttributeValue = DateTimeOffset.ParseExact(s.Substring(dateTimeOffsetPrefix.Length), "o", CultureInfo.InvariantCulture);
}
}

var user = new User("12345")
{
Custom =
{
["Custom1"] = customAttributeValue
}
};

const string defaultValue = "default";
var actualReturnValue = evaluator.Evaluate(config!.Settings, key, defaultValue, user, remoteConfig: null, logger).Value;

Assert.AreEqual(expectedReturnValue, actualReturnValue);
}

[DataTestMethod]
[DataRow("isoneof", "no trim")]
[DataRow("isnotoneof", "no trim")]
[DataRow("isoneofhashed", "no trim")]
[DataRow("isnotoneofhashed", "no trim")]
[DataRow("equalshashed", "no trim")]
[DataRow("notequalshashed", "no trim")]
[DataRow("arraycontainsanyofhashed", "no trim")]
[DataRow("arraynotcontainsanyofhashed", "no trim")]
[DataRow("equals", "no trim")]
[DataRow("notequals", "no trim")]
[DataRow("startwithanyof", "no trim")]
[DataRow("notstartwithanyof", "no trim")]
[DataRow("endswithanyof", "no trim")]
[DataRow("notendswithanyof", "no trim")]
[DataRow("arraycontainsanyof", "no trim")]
[DataRow("arraynotcontainsanyof", "no trim")]
[DataRow("startwithanyofhashed", "no trim")]
[DataRow("notstartwithanyofhashed", "no trim")]
[DataRow("endswithanyofhashed", "no trim")]
[DataRow("notendswithanyofhashed", "no trim")]
//semver comparators user values trimmed because of backward compatibility
[DataRow("semverisoneof", "4 trim")]
[DataRow("semverisnotoneof", "5 trim")]
[DataRow("semverless", "6 trim")]
[DataRow("semverlessequals", "7 trim")]
[DataRow("semvergreater", "8 trim")]
[DataRow("semvergreaterequals", "9 trim")]
//number and date comparators user values trimmed because of backward compatibility
[DataRow("numberequals", "10 trim")]
[DataRow("numbernotequals", "11 trim")]
[DataRow("numberless", "12 trim")]
[DataRow("numberlessequals", "13 trim")]
[DataRow("numbergreater", "14 trim")]
[DataRow("numbergreaterequals", "15 trim")]
[DataRow("datebefore", "18 trim")]
[DataRow("dateafter", "19 trim")]
//"contains any of" and "not contains any of" is a special case, the not trimmed user attribute checked against not trimmed comparator values.
[DataRow("containsanyof", "no trim")]
[DataRow("notcontainsanyof", "no trim")]
public void ComparisonAttributeTrimming_Test(string key, string expectedReturnValue)
{
var config = new ConfigLocation.LocalFile("data", "comparison_attribute_trimming.json").FetchConfig();

var logger = new Mock<IConfigCatLogger>().Object.AsWrapper();
var evaluator = new RolloutEvaluator(logger);

var user = new User(" 12345 ")
{
Country = "[\" USA \"]",
Custom =
{
["Version"] = " 1.0.0 ",
["Number"] = " 3 ",
["Date"] = " 1705253400 "
}
};

const string defaultValue = "default";
var actualReturnValue = evaluator.Evaluate(config!.Settings, key, defaultValue, user, remoteConfig: null, logger).Value;

Assert.AreEqual(expectedReturnValue, actualReturnValue);
}

[DataTestMethod]
[DataRow("isoneof", "no trim")]
[DataRow("isnotoneof", "no trim")]
[DataRow("containsanyof", "no trim")]
[DataRow("notcontainsanyof", "no trim")]
[DataRow("isoneofhashed", "no trim")]
[DataRow("isnotoneofhashed", "no trim")]
[DataRow("equalshashed", "no trim")]
[DataRow("notequalshashed", "no trim")]
[DataRow("arraycontainsanyofhashed", "no trim")]
[DataRow("arraynotcontainsanyofhashed", "no trim")]
[DataRow("equals", "no trim")]
[DataRow("notequals", "no trim")]
[DataRow("startwithanyof", "no trim")]
[DataRow("notstartwithanyof", "no trim")]
[DataRow("endswithanyof", "no trim")]
[DataRow("notendswithanyof", "no trim")]
[DataRow("arraycontainsanyof", "no trim")]
[DataRow("arraynotcontainsanyof", "no trim")]
[DataRow("startwithanyofhashed", "default")]
[DataRow("notstartwithanyofhashed", "default")]
[DataRow("endswithanyofhashed", "default")]
[DataRow("notendswithanyofhashed", "default")]
//semver comparator values trimmed because of backward compatibility
[DataRow("semverisoneof", "4 trim")]
[DataRow("semverisnotoneof", "5 trim")]
[DataRow("semverless", "6 trim")]
[DataRow("semverlessequals", "7 trim")]
[DataRow("semvergreater", "8 trim")]
[DataRow("semvergreaterequals", "9 trim")]
public void ComparisonValueTrimming_Test(string key, string expectedReturnValue)
{
var config = new ConfigLocation.LocalFile("data", "comparison_value_trimming.json").FetchConfig();

var logger = new Mock<IConfigCatLogger>().Object.AsWrapper();
var evaluator = new RolloutEvaluator(logger);

var user = new User("12345")
{
Country = "[\"USA\"]",
Custom =
{
["Version"] = "1.0.0",
["Number"] = "3",
["Date"] = "1705253400"
}
};

const string defaultValue = "default";
string actualReturnValue;
try { actualReturnValue = evaluator.Evaluate(config!.Settings, key, defaultValue, user, remoteConfig: null, logger).Value; }
catch (InvalidOperationException) { actualReturnValue = defaultValue; }

Assert.AreEqual(expectedReturnValue, actualReturnValue);
}
}
Loading
Loading