Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More config v6 tests #88

Merged
merged 13 commits into from
Feb 8, 2024
Merged

More config v6 tests #88

merged 13 commits into from
Feb 8, 2024

Conversation

adams85
Copy link
Contributor

@adams85 adams85 commented Jan 30, 2024

Describe the purpose of your pull request

Adds a few additional test cases for testing config v6 features.

Also, fixes a few edge cases where user attribute values was not converted to their canonical string representations.

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@adams85 adams85 requested a review from a team as a code owner January 30, 2024 12:53
@adams85 adams85 force-pushed the more-configv6-tests branch 3 times, most recently from c51e24a to ca3d3da Compare January 30, 2024 16:05
@adams85 adams85 force-pushed the more-configv6-tests branch from ca3d3da to 229297c Compare January 30, 2024 16:18
@adams85 adams85 force-pushed the more-configv6-tests branch from a89ce64 to 23f0a2b Compare February 2, 2024 09:28
@adams85 adams85 force-pushed the more-configv6-tests branch from 9d402ee to e779937 Compare February 5, 2024 19:52
@adams85
Copy link
Contributor Author

adams85 commented Feb 5, 2024

ConfigCat.Client.Benchmarks.MatrixTestBenchmark (LogInfo = False)

Diff Method Mean Error Allocated
Old MatrixTests_ConfigV6 17.61 ms 0.504 ms 13.84 MB
New 15.71 ms (-11%) 0.469 ms 11.75 MB (-15%)

@adams85 adams85 force-pushed the more-configv6-tests branch from aae6dc9 to fb6bab8 Compare February 6, 2024 14:10
@adams85 adams85 force-pushed the more-configv6-tests branch from fb6bab8 to a63cf49 Compare February 6, 2024 14:14
Copy link

sonarcloud bot commented Feb 8, 2024

@adams85 adams85 merged commit 2abf583 into master Feb 8, 2024
6 of 7 checks passed
@adams85 adams85 deleted the more-configv6-tests branch February 8, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants