Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit some issues with scheduled runs and upstream tests collection #223

Merged
merged 12 commits into from
Jul 12, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jun 26, 2023

Description

Fix a couple issues where a failed scheduled run wouldn't trigger a new issue notifying us of the problem. This PR also revisits the pytest collection from upstream conda/conda so we have more control over it; it uses a pytest plugin (dev/collect_upstream_conda_tests), which needs to be installed in the same environment as pytest.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 26, 2023
@jaimergp
Copy link
Contributor Author

This PR is also uncovering the errors we see on main, which started happening on June 16th for conda-forge. Note their equivalents with defaults do pass.

  • Linux, macOS and Windows:
    • conda/tests/core/test_solve.py::test_force_remove_1
    • conda/tests/core/test_solve.py::test_aggressive_update_packages
    • conda-libmamba-solver/tests/test_modified_upstream.py::test_pinned_1
  • Linux only:
    • conda/tests/test_create.py::test_conda_pip_interop_dependency_satisfied_by_pip
    • conda/tests/test_create.py::test_conda_pip_interop_pip_clobbers_conda
    • conda/tests/test_create.py::test_install_tarball_from_local_channel

@jaimergp
Copy link
Contributor Author

Turns out the failures were #186 hitting again after 1.4.4 was released on June 16th. I've added a pytest plugin (WIP) to collect tests conditionally depending on what's available. This is also cleaner than overriding the pyproject.toml / setup.cfg config in conda/conda.

@jaimergp jaimergp mentioned this pull request Jul 4, 2023
3 tasks
@jaimergp
Copy link
Contributor Author

jaimergp commented Jul 4, 2023

pre-commit.ci autofix

@costrouc
Copy link
Contributor

All green 😄. @jaimergp does this deserve news?

@jaimergp jaimergp marked this pull request as ready for review July 10, 2023 14:53
@jaimergp jaimergp changed the title Revisit some issues with scheduled runs Revisit some issues with scheduled runs and upstream tests collection Jul 10, 2023
@jaimergp
Copy link
Contributor Author

@costrouc, yay! In that case can you do a quick review? Thanks!

@jaimergp
Copy link
Contributor Author

And it's an internal thingy for our own test suite, not sure it needs a news entry. I edited the PR description just in case.

@jaimergp jaimergp requested review from costrouc and jezdez and removed request for costrouc July 10, 2023 15:25
@jezdez jezdez merged commit ea712cc into main Jul 12, 2023
@jaimergp jaimergp deleted the post-issues-on-scheduled-runs branch July 13, 2023 10:27
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants