-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit some issues with scheduled runs and upstream tests collection #223
Conversation
This PR is also uncovering the errors we see on
|
Turns out the failures were #186 hitting again after 1.4.4 was released on June 16th. I've added a pytest plugin (WIP) to collect tests conditionally depending on what's available. This is also cleaner than overriding the pyproject.toml / setup.cfg config in |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
All green 😄. @jaimergp does this deserve news? |
@costrouc, yay! In that case can you do a quick review? Thanks! |
And it's an internal thingy for our own test suite, not sure it needs a news entry. I edited the PR description just in case. |
Description
Fix a couple issues where a failed scheduled run wouldn't trigger a new issue notifying us of the problem. This PR also revisits the pytest collection from upstream
conda/conda
so we have more control over it; it uses a pytest plugin (dev/collect_upstream_conda_tests
), which needs to be installed in the same environment aspytest
.Checklist - did you ...
Add a file to thenews
directory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?