Fix disappearing channel matchspecs #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
2 tasks
costrouc
reviewed
Jul 1, 2023
| spec_str = str(spec) | ||
| if "::" in spec_str: | ||
| for arg in sys.argv: | ||
| if spec_str in arg: | ||
| spec = MatchSpec(arg) | ||
| ms_from_arg = MatchSpec(arg) |
There was a problem hiding this comment.
I checked this PR when running and it does fix the issue but
conda create -n test -d conda-forge::jax conda-forge::jaxlibspecs_to_add is of type List[str] so the elif isinstance(spec, MatchSpec): branch is not touched. Is this intended? If so I am wondering why you are modifying lines 114 & 115. Checked this using breakpoints.
There was a problem hiding this comment.
Ah, good catch! I think it might be the case in some tests that are passing List[MatchSpec] directly. We'll have a clearer view when #223 is merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Will close #221
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?