Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.6] feat: force PHP default 32 chars length at 4 bits to Session ID #9139

Merged
merged 3 commits into from
Sep 5, 2024
Merged

[4.6] feat: force PHP default 32 chars length at 4 bits to Session ID #9139

merged 3 commits into from
Sep 5, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 22, 2024 •
edited
Loading

Description
Supersedes #9135
See #9116 and #9116 (comment)

These INI settings have been deprecated in PHP 8.4.
This PR enforces the behavior in PHP 9.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added breaking change Pull requests that may break existing functionalities 4.6 labels Aug 22, 2024
@kenjis kenjis changed the title [4.6] Force PHP default 32 chars length at 4 bits to Session ID [4.6] fix: Force PHP default 32 chars length at 4 bits to Session ID Aug 22, 2024
@kenjis kenjis changed the title [4.6] fix: Force PHP default 32 chars length at 4 bits to Session ID [4.6] feat: Force PHP default 32 chars length at 4 bits to Session ID Aug 22, 2024
@kenjis kenjis added the enhancement PRs that improve existing functionalities label Aug 22, 2024
This was referenced Aug 22, 2024
Open
Merged
@kenjis kenjis changed the title [4.6] feat: Force PHP default 32 chars length at 4 bits to Session ID [4.6] feat: force PHP default 32 chars length at 4 bits to Session ID Aug 22, 2024
@kenjis kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Aug 22, 2024
@kenjis kenjis force-pushed the session-sid-change branch from c9434c9 to 5879417 Compare August 27, 2024 05:14
@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Aug 27, 2024
@kenjis
Copy link
Member Author

kenjis commented Aug 27, 2024

Added docs.

@github-actions github-actions bot added the stale Pull requests with conflicts label Aug 30, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis force-pushed the session-sid-change branch from 5879417 to 703c273 Compare August 30, 2024 00:07
@kenjis kenjis removed the stale Pull requests with conflicts label Aug 30, 2024
@kenjis
Copy link
Member Author

kenjis commented Aug 30, 2024

Rebased to resolve conflicts.

@kenjis kenjis merged commit 8442cb1 into codeigniter4:4.6 Sep 5, 2024
46 checks passed
@kenjis kenjis deleted the session-sid-change branch September 5, 2024 01:26
@tenzap tenzap mentioned this pull request Sep 29, 2024
Open
@NielBuys NielBuys mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.6 breaking change Pull requests that may break existing functionalities enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn