-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.6] feat: workaround for implicit nullable deprecations in PHP 8.4 #9140
[4.6] feat: workaround for implicit nullable deprecations in PHP 8.4 #9140
Conversation
b483b9e
to
ba1702f
Compare
This PR would fix the following errors:
https://github.com/codeigniter4/CodeIgniter4/actions/runs/10712255682/job/29702517072 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is a workaround only for the current implementation of Kint
and Faker
? If so, why do we mask all instances, not just those coming from these libraries?
This is a workaround for the dependent packages that are not compatible with PHP 8.4. So we should not skip all implicit nullable deprecations.
Thanks. I added code to check if it is caused by Faker or Kint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hopefully these libraries will be updated before the release of PHP 8.4.
Needs #9139Description
See #9116
Checklist: