Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove the ignore errors of View in phpstan. #7794

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Fix: Remove the ignore errors of View in phpstan. #7794

merged 4 commits into from
Aug 10, 2023

Conversation

ya861220
Copy link
Contributor

@ya861220 ya861220 commented Aug 8, 2023

Description
See #7731

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ya861220 ya861220 changed the title fix: Remove the ignore errors of View in phpstan. Fix: Remove the ignore errors of View in phpstan. Aug 8, 2023
MGatner
MGatner requested changes Aug 8, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on these errors! A few changes noted, if you please.

system/View/Cell.php Outdated Show resolved Hide resolved
system/View/Exceptions/ViewException.php Outdated Show resolved Hide resolved
@datamweb datamweb mentioned this pull request Aug 10, 2023
Merged
5 tasks
kenjis
kenjis approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit b6c3977 into codeigniter4:develop Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner requested changes

@paulbalandan paulbalandan paulbalandan approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ya861220 @kenjis @MGatner @paulbalandan