Fix: Remove the ignore errors of HTTP in phpstan.
#7803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datamweb
suggested changes
Aug 10, 2023
system/HTTP/DownloadResponse.php
Outdated
Comment on lines
135
to
132
| * | ||
| * @return void | ||
| */ | ||
| private function setContentTypeByMimeType() |
There was a problem hiding this comment.
Suggested change
| * | |
| * @return void | |
| */ | |
| private function setContentTypeByMimeType() | |
| */ | |
| private function setContentTypeByMimeType(): void |
see #7794 (comment)
|
Please rebase to resolve conflicts. |
|
If you don't know how to use git, I recommend you try https://learngitbranching.js.org/ |
ya861220
force-pushed
the
230809-phpstan-HTTP
branch
from
59bdb59 to
d8bd77f
Compare
kenjis
reviewed
Aug 12, 2023
| @@ -59,6 +59,8 @@ public function __construct(string $path, string $originalName, ?string $mimeTyp | |||
| * @param string $targetPath Path to which to move the uploaded file. | |||
| * @param string $name the name to rename the file to. | |||
| * | |||
| * @return void | |||
There was a problem hiding this comment.
Suggested change
| * @return void | |
| * @return bool |
kenjis
approved these changes
Aug 12, 2023
MGatner
approved these changes
Aug 12, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #7731
Checklist: