Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove the system-Exception ignore errors. #7791

Conversation

kai890707
Copy link
Contributor

Description
See #7731

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kai890707 kai890707 changed the title Dev: Remove the system-Exception ignore errors. Dev: Remove the system-Exception ignore errors. Aug 8, 2023
@kai890707 kai890707 changed the title Dev: Remove the system-Exception ignore errors. Fix: Remove the system-Exception ignore errors. Aug 8, 2023
system/Exceptions/CastException.php Outdated Show resolved Hide resolved
paulbalandan
paulbalandan previously approved these changes Aug 9, 2023
@kenjis kenjis added the stale Pull requests with conflicts label Aug 10, 2023
@kenjis
Copy link
Member

kenjis commented Aug 10, 2023

@kai890707
Copy link
Contributor Author

Please rebase to resolve conflicts. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

I synchronized the current develop branch and ran phpstan.

@kenjis
Copy link
Member

kenjis commented Aug 10, 2023

I synchronized the current develop branch and ran phpstan.

What is synchronized ? What did you do exactly?

This branch is broken. See the diffs:
https://github.com/codeigniter4/CodeIgniter4/pull/7791/files
and this branch still has conflicts.

@kenjis
Copy link
Member

kenjis commented Aug 11, 2023

If you don't know how to use git, I recommend you try https://learngitbranching.js.org/

@paulbalandan paulbalandan self-requested a review August 15, 2023 05:30
@paulbalandan paulbalandan dismissed their stale review August 15, 2023 05:30

For re-review after rebase

@kai890707 kai890707 closed this Aug 16, 2023
@kai890707 kai890707 force-pushed the 20230808-system-Exception-phpstan branch from 9311253 to 84c28a9 Compare August 16, 2023 15:54
@kai890707 kai890707 deleted the 20230808-system-Exception-phpstan branch August 16, 2023 15:54
@kai890707 kai890707 restored the 20230808-system-Exception-phpstan branch August 16, 2023 15:54
@kai890707 kai890707 deleted the 20230808-system-Exception-phpstan branch August 16, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Pull requests with conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants