Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove the system-Exception ignore errors. #7829

Merged

Conversation

kai890707
Copy link
Contributor

Description
See #7731

Sorry, There was a conflict with a previous modification (#7791) and due to my operational issues I have reorganized the complete modification into a new PR.

Thanks to @kenjis for the relevant advice, I will read it in detail and apologize for the distress I have caused!

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
Copy link
Member

kenjis commented Aug 16, 2023

@kai890707 Thank you for update!
No problem. Git is very difficult, and it takes time to learn.

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit d580507 into codeigniter4:develop Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants