chore: Migrate useSelfHostedSeatsConfig to TS Query V5 #3580
Conversation
Bundle ReportChanges will increase total bundle size by 650.39kB (3.71%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 650.39kB (3.71%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
==========================================
- Coverage 98.91% 98.90% -0.01%
==========================================
Files 806 810 +4
Lines 14478 14568 +90
Branches 4105 4144 +39
==========================================
+ Hits 14321 14409 +88
- Misses 150 152 +2
Partials 7 7
... and 28 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3580 +/- ##
==========================================
- Coverage 98.91% 98.90% -0.01%
==========================================
Files 806 810 +4
Lines 14478 14568 +90
Branches 4105 4144 +39
==========================================
+ Hits 14321 14409 +88
- Misses 150 152 +2
Partials 7 7
... and 28 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3580 +/- ##
==========================================
- Coverage 98.91% 98.90% -0.01%
==========================================
Files 806 810 +4
Lines 14478 14568 +90
Branches 4112 4151 +39
==========================================
+ Hits 14321 14409 +88
- Misses 150 152 +2
Partials 7 7
... and 28 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3580 +/- ##
==========================================
- Coverage 98.91% 98.90% -0.01%
==========================================
Files 806 810 +4
Lines 14478 14568 +90
Branches 4105 4144 +39
==========================================
+ Hits 14321 14409 +88
- Misses 150 152 +2
Partials 7 7
... and 28 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
| }, | ||
| onSettled: () => { | ||
| queryClient.invalidateQueries(['SelfHostedCurrentUser']) | ||
| queryClient.invalidateQueries(['Seats']) | ||
| queryClientV5.invalidateQueries( | ||
| SelfHostedSeatsConfigQueryOpts({ provider }).queryKey |
There was a problem hiding this comment.
just making sure - is this provider key used in the lookup case-sensitive at all? Just in case that misses hits between like GITHUB, github, .. Oh and I guess also the shorthand like gh.
There was a problem hiding this comment.
yes it would be case sensitive, however the data fetching query key is also case sensitive so they would align on that level and ensure that the correct value in the cache gets cleared.
Description
This PR migrates the
useSelfHostedSeatsConfigto the TS Query V5 queryOptions versionSelfHostedSeatsConfigQueryOptsTicket: codecov/engineering-team#2961
Notable Changes
useSelfHostedSeatsConfigtoSelfHostedSeatsConfigQueryOptsSeatDetails,ActivationBanner,ActivationRequiredSelfHosted,ActivationRequiredSelfHostedProfiletests