-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate useSelfHostedCurrentUser to TS Query V5 #3582
base: main
Are you sure you want to change the base?
chore: Migrate useSelfHostedCurrentUser to TS Query V5 #3582
Conversation
Bundle ReportChanges will decrease total bundle size by 2.43kB (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will decrease total bundle size by 2.43kB (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3582 +/- ##
==========================================
- Coverage 98.91% 98.91% -0.01%
==========================================
Files 806 806
Lines 14498 14505 +7
Branches 4119 4113 -6
==========================================
+ Hits 14341 14347 +6
- Misses 150 151 +1
Partials 7 7
... and 19 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3582 +/- ##
==========================================
- Coverage 98.91% 98.91% -0.01%
==========================================
Files 806 806
Lines 14498 14505 +7
Branches 4112 4120 +8
==========================================
+ Hits 14341 14347 +6
- Misses 150 151 +1
Partials 7 7
... and 19 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3582 +/- ##
==========================================
- Coverage 98.91% 98.91% -0.01%
==========================================
Files 806 806
Lines 14498 14505 +7
Branches 4112 4113 +1
==========================================
+ Hits 14341 14347 +6
- Misses 150 151 +1
Partials 7 7
... and 19 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3582 +/- ##
==========================================
- Coverage 98.91% 98.91% -0.01%
==========================================
Files 806 806
Lines 14498 14505 +7
Branches 4119 4120 +1
==========================================
+ Hits 14341 14347 +6
- Misses 150 151 +1
Partials 7 7
... and 19 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
const { data } = useSelfHostedCurrentUser() | ||
const { provider } = useParams<URLParams>() | ||
const { data } = useSuspenseQueryV5( | ||
SelfHostedCurrentUserQueryOpts({ provider }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same Q re: provider is case-sensitive here? - #3580 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answer in the previous thread
Description
This PR migrates the
useSelfHostedCurrentUser
to the TS Query V5 queryOptions API versionSelfHostedCurrentUserQueryOpts
Ticket: codecov/engineering-team#2961
Notable Changes
useSelfHostedCurrentUser
toSelfHostedCurrentUserQueryOpts
AdminLink
,Profile
,ActivationBanner
,useSelfActivationMutation
,AdminSettings
, ActivationRequiredSelfHosted` x 2