Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Dep update, Oct. 25, 2024 #185

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

chore: Dep update, Oct. 25, 2024 #185

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
11d3d9b
update rollup versions
nicholas-codecov Oct 25, 2024
e6e38c9
update next integration tests to 15
nicholas-codecov Oct 25, 2024
457c088
update nuxt snapshot
nicholas-codecov Oct 25, 2024
8bf2ce4
add in changeset
nicholas-codecov Oct 25, 2024
5bb8997
pin the version of rollup in the rollup plugin
nicholas-codecov Oct 25, 2024
7442bd6
resolve some other issues after moving to next 15
nicholas-codecov Oct 28, 2024
6a09b5a
remove commented out code
nicholas-codecov Oct 28, 2024
0f5fa62
ignore eslint during build in integration test next config
nicholas-codecov Oct 28, 2024
efb8485
temp disable node 18 runs
nicholas-codecov Oct 28, 2024
f349290
doesn't seem like it was a node 18 issue
nicholas-codecov Oct 28, 2024
d3477db
bring everything to what they have in a freshly bootstrapped next app
nicholas-codecov Oct 28, 2024
e548b40
forgot to bring back the plugin
nicholas-codecov Oct 28, 2024
76afeb3
forgot to re-run to generate the new lock file
nicholas-codecov Oct 28, 2024
d68d8c6
run integration tests individually to see what's actually going on
nicholas-codecov Oct 29, 2024
87d660f
didn't have correct bundle name to find
nicholas-codecov Oct 29, 2024
0a5ae33
missed v14 to v15
nicholas-codecov Oct 29, 2024
dab33a9
idk maybe bumping will do the trick
nicholas-codecov Oct 29, 2024
c0cf85d
once again forgot to update the lock file
nicholas-codecov Oct 29, 2024
1944b93
update test next app to follow more like the latest generated app
nicholas-codecov Oct 31, 2024
8e34196
run next info before building
nicholas-codecov Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/thirty-yaks-exercise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
"@codecov/rollup-plugin": minor
"@codecov/bundle-analyzer": minor
"@codecov/bundler-plugin-core": minor
"@codecov/nextjs-webpack-plugin": minor
"@codecov/nuxt-plugin": minor
"@codecov/remix-vite-plugin": minor
"@codecov/solidstart-plugin": minor
"@codecov/sveltekit-plugin": minor
"@codecov/vite-plugin": minor
"@codecov/webpack-plugin": minor
---

Bumping minor version for Rollup updates
6 changes: 3 additions & 3 deletions examples/bundle-analyzer-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
"devDependencies": {
"@codecov/bundle-analyzer": "workspace:^",
"@codecov/rollup-plugin": "workspace:^",
"@rollup/plugin-commonjs": "^25.0.7",
"@rollup/plugin-node-resolve": "^15.2.3",
"@rollup/plugin-commonjs": "^28.0.1",
"@rollup/plugin-node-resolve": "^15.3.0",
"npm-run-all": "^4.1.5",
"rollup": "^4.9.6",
"rollup": "^4.24.0",
"serve": "^14.2.1"
},
"volta": {
Expand Down
2 changes: 1 addition & 1 deletion examples/next-js-15/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"lint": "next lint"
},
"dependencies": {
"next": "15.0.0-rc.0",
"next": "^15.0.1",
"react": "19.0.0-rc-b57d2823-20240822",
"react-dom": "19.0.0-rc-b57d2823-20240822"
},
Expand Down
2 changes: 1 addition & 1 deletion examples/oidc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"eslint": "^8.56.0",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-refresh": "^0.4.5",
"rollup": "^4.9.6",
"rollup": "^4.24.0",
"typescript": "^5.3.3",
"vite": "^5.2.10"
},
Expand Down
6 changes: 3 additions & 3 deletions examples/rollup/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
},
"devDependencies": {
"@codecov/rollup-plugin": "workspace:^",
"@rollup/plugin-commonjs": "^25.0.7",
"@rollup/plugin-node-resolve": "^15.2.3",
"@rollup/plugin-commonjs": "^28.0.1",
"@rollup/plugin-node-resolve": "^15.3.0",
"npm-run-all": "^4.1.5",
"rollup": "^4.9.6",
"rollup": "^4.24.0",
"serve": "^14.2.1"
},
"volta": {
Expand Down
2 changes: 1 addition & 1 deletion examples/tokenless/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"eslint": "^8.56.0",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-refresh": "^0.4.5",
"rollup": "^4.9.6",
"rollup": "^4.24.0",
"typescript": "^5.3.3",
"vite": "^5.2.10"
},
Expand Down
4 changes: 2 additions & 2 deletions examples/vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
"eslint": "^8.56.0",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-refresh": "^0.4.5",
"rollup": "^4.9.6",
"rollup": "^4.24.0",
"typescript": "^5.3.3",
"vite": "^5.2.10"
"vite": "^5.4.10"
},
"volta": {
"extends": "../../package.json"
Expand Down
29 changes: 25 additions & 4 deletions ...tion-tests/fixtures/generate-bundle-stats/nextjs/__snapshots__/nextjs-plugin.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ exports[`Generating nextjs stats 14 matches the snapshot 1`] = `
}
`;

exports[`Generating nextjs stats 14 matches the snapshot 2`] = `
exports[`Generating nextjs stats 15 matches the snapshot 2`] = `
{
"assets": ExpectArrayContaining {},
"builtAt": Any<Number>,
"bundleName": StringContaining "test-nextjs-v14-server-cjs",
"bundleName": StringContaining "test-nextjs-v15-server-cjs",
"bundler": {
"name": Any<String>,
"version": Any<String>,
Expand All @@ -42,11 +42,32 @@ exports[`Generating nextjs stats 14 matches the snapshot 2`] = `
}
`;

exports[`Generating nextjs stats 14 matches the snapshot 3`] = `
exports[`Generating nextjs stats 15 matches the snapshot 3`] = `
{
"assets": ExpectArrayContaining {},
"builtAt": Any<Number>,
"bundleName": StringContaining "test-nextjs-v14-edge-server-array-push",
"bundleName": StringContaining "test-nextjs-v15-edge-server-array-push",
"bundler": {
"name": Any<String>,
"version": Any<String>,
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
"modules": ExpectArrayContaining {},
"outputPath": Any<String>,
"plugin": {
"name": StringMatching "@codecov/nextjs-webpack-plugin",
"version": Any<String>,
},
"version": Any<String>,
}
`;

exports[`Generating nextjs stats 15 matches the snapshot 1`] = `
{
"assets": ExpectArrayContaining {},
"builtAt": Any<Number>,
"bundleName": StringContaining "test-nextjs-v15-client-array-push",
"bundler": {
"name": Any<String>,
"version": Any<String>,
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/fixtures/generate-bundle-stats/nextjs/next-base.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export default {
config.plugins.push(
codecovNextJSWebpackPlugin({
enableBundleAnalysis: true,
bundleName: "test-nextjs-v14",
bundleName: "test-nextjs-v15",
uploadToken: "test-token",
apiUrl: process.env.API_URL,
webpack: options.webpack,
Expand Down
8 changes: 4 additions & 4 deletions integration-tests/fixtures/generate-bundle-stats/nextjs/nextjs-plugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { GenerateConfig } from "../../../scripts/gen-config";

const nextjsApp = "test-apps/nextjs";

const VERSIONS = [14];
const VERSIONS = [15];

describe("Generating nextjs stats", () => {
describe.each(VERSIONS)("%d", (version) => {
Expand All @@ -15,8 +15,8 @@ describe("Generating nextjs stats", () => {
configFileName: "next",
format: "esm",
detectFormat: "esm",
version: `v14`,
detectVersion: "v14",
version: `v15`,
detectVersion: "v15",
file_format: "mjs",
enableSourceMaps: false,
overrideOutputPath: `${nextjsApp}/next.config.mjs`,
Expand Down Expand Up @@ -193,7 +193,7 @@ describe("Generating nextjs stats", () => {
});

await config.createConfig();
config.removeBundleName(`test-nextjs-v14`);
config.removeBundleName(`test-nextjs-v15`);
await config.writeConfig();
});

Expand Down
36 changes: 18 additions & 18 deletions integration-tests/fixtures/generate-bundle-stats/nuxt/__snapshots__/nuxt-plugin.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports[`Generating nuxt stats 3 {"format":"amd","expected":"amd"} matches the s
"bundleName": StringContaining "test-nuxt-v3-client-amd",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -28,7 +28,7 @@ exports[`Generating nuxt stats 3 {"format":"amd","expected":"amd"} matches the s
"bundleName": StringContaining "test-nuxt-v3-server-esm",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -49,7 +49,7 @@ exports[`Generating nuxt stats 3 {"format":"cjs","expected":"cjs"} matches the s
"bundleName": StringContaining "test-nuxt-v3-client-cjs",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -70,7 +70,7 @@ exports[`Generating nuxt stats 3 {"format":"cjs","expected":"cjs"} matches the s
"bundleName": StringContaining "test-nuxt-v3-server-esm",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -91,7 +91,7 @@ exports[`Generating nuxt stats 3 {"format":"es","expected":"esm"} matches the sn
"bundleName": StringContaining "test-nuxt-v3-client-esm",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -112,7 +112,7 @@ exports[`Generating nuxt stats 3 {"format":"es","expected":"esm"} matches the sn
"bundleName": StringContaining "test-nuxt-v3-server-esm",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -133,7 +133,7 @@ exports[`Generating nuxt stats 3 {"format":"esm","expected":"esm"} matches the s
"bundleName": StringContaining "test-nuxt-v3-client-esm",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -154,7 +154,7 @@ exports[`Generating nuxt stats 3 {"format":"esm","expected":"esm"} matches the s
"bundleName": StringContaining "test-nuxt-v3-server-esm",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -175,7 +175,7 @@ exports[`Generating nuxt stats 3 {"format":"module","expected":"esm"} matches th
"bundleName": StringContaining "test-nuxt-v3-client-esm",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -196,7 +196,7 @@ exports[`Generating nuxt stats 3 {"format":"module","expected":"esm"} matches th
"bundleName": StringContaining "test-nuxt-v3-server-esm",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -217,7 +217,7 @@ exports[`Generating nuxt stats 3 {"format":"iife","expected":"iife"} matches the
"bundleName": StringContaining "test-nuxt-v3-client-iife",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -238,7 +238,7 @@ exports[`Generating nuxt stats 3 {"format":"iife","expected":"iife"} matches the
"bundleName": StringContaining "test-nuxt-v3-server-esm",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -259,7 +259,7 @@ exports[`Generating nuxt stats 3 {"format":"umd","expected":"umd"} matches the s
"bundleName": StringContaining "test-nuxt-v3-client-umd",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -280,7 +280,7 @@ exports[`Generating nuxt stats 3 {"format":"umd","expected":"umd"} matches the s
"bundleName": StringContaining "test-nuxt-v3-server-esm",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -301,7 +301,7 @@ exports[`Generating nuxt stats 3 {"format":"system","expected":"system"} matches
"bundleName": StringContaining "test-nuxt-v3-client-system",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -322,7 +322,7 @@ exports[`Generating nuxt stats 3 {"format":"system","expected":"system"} matches
"bundleName": StringContaining "test-nuxt-v3-server-esm",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -343,7 +343,7 @@ exports[`Generating nuxt stats 3 {"format":"systemjs","expected":"system"} match
"bundleName": StringContaining "test-nuxt-v3-client-system",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand All @@ -364,7 +364,7 @@ exports[`Generating nuxt stats 3 {"format":"systemjs","expected":"system"} match
"bundleName": StringContaining "test-nuxt-v3-server-esm",
"bundler": {
"name": "rollup",
"version": "4.21.2",
"version": "4.24.0",
},
"chunks": ExpectArrayContaining {},
"duration": Any<Number>,
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/test-apps/nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"dependencies": {
"react": "^18",
"react-dom": "^18",
"next": "14.2.5"
"next": "^15.0.1"
},
"devDependencies": {
"@codecov/nextjs-webpack-plugin": "workspace:^",
Expand Down
2 changes: 1 addition & 1 deletion packages/rollup-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"@vitest/coverage-v8": "^1.5.0",
"codecovProdRollupPlugin": "npm:@codecov/[email protected]",
"msw": "^2.1.5",
"rollup": "4.9.6",
"rollup": "4.24.0",
"ts-node": "^10.9.2",
"typedoc": "^0.25.12",
"typescript": "^5.3.3",
Expand Down
Loading
Loading