Use ESLint and PrettierJS

[4yman-0]

closes #2724

TODO:

• Add PrettierJS
• Better configuration:
  • ESLint
  • Prettier
• Fix undefined document and other browser APIs

[ImprovedTube]

hi! @4yman-0 woaw +1,115 −930

i saw some version number go down too?
can we keep files in a sub-folder?

[ImprovedTube]

hi! previously @dodieboy customized this. And @raszpl. (And i tried adding CSS linting)

down

won't

why / which other subfolder fits better?

[4yman-0]

hi! previously @dodieboy customized this. And @raszpl. (And i tried adding CSS linting)

I ran node update and some magic to add ESlint and PrettierJS. In ESLint's "flat" configuration file, I used the recommended options with very little customization. Prettier's config can be improved. As for CSSLint, it didn't work so I removed it.

why / which other subfolder fits better?

Why?

The tests folder shouldn't contain config files the same way images and css don't fit in one directory.

Which?

• config

I don't know if all the tools will work with custom config paths.

Edit: typo

[ImprovedTube]

just not sure how much time the guys spent yet on customizing ESlinting rules /policy. #2446 #2438

---

(
Generally debugging can be enforced;
Better methods can be strongly suggested;
White-spaces suggestions can be friendly options only, since they only matter, if they are intentionally placed (When fully following beauty-standards, then one could also simply remove all white-space from all code and commits / PRs, while everybody could always chose their own local flavor /"IDE-theme", instead of actually keeping any white-space in any repo. Same would work with some intentionally different white-spaces present, but instead of them being the only ones removed, they would be, the only ones to stay and maybe color-marked up or so)

CSSLint, didn't work so I removed it.

i might tend to resign late (why not?)
)

[ImprovedTube]

Jest breaks when I choose it with --config

yes 🤔 tests & config in one folder are intuitive for newbies and not a bad difference otherwise. Yet i just wanted to keep the root directory empty and the readme.md up, which isn't important enough /a lost cause😂

[dodieboy]

Most of the lint config is based on @raszpl and the original format of this project to standardise how this project present our code. I'm ok with the config as long as @ImprovedTube is ok with it.

Prettier is a good tool too, I often use it with my vscode.

[ImprovedTube]

i saw some version number go down too?

(all could say latest?)

[ImprovedTube]

hi @dodieboy thank you! hope you are fine!

[dodieboy]

i saw some version number go down too?

(all could say latest?)

Truly say, it is not recommended to used latest, as it will result in auto update and our config may break. @4yman-0 for changing on that part but any reason to downgrade eslint from v9 to V8?

[4yman-0]

reason to downgrade eslint from v9 to V8?

None.

[ImprovedTube]

hi @4yman-0
(...good point thinking of build.py too! not currently using it, but should (if not even better, through github actions; Currently building 4 different versions manually)
(as always, editing that felt a bit productive/meaningful, removing nothing but hoarding ("readme.md" "previews" "py"), so that the code could be repurposed. "Everything as a framework")