Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add .gitignore file to exclude common build and dependency files #2717

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ImBIOS
Copy link

@ImBIOS ImBIOS commented Dec 10, 2024

No description provided.

@ImBIOS
Copy link
Author

ImBIOS commented Dec 12, 2024

@4yman-0 can we merge it?

@ImprovedTube
Copy link
Member

hi and thanks! @ImBIOS

@4yman-0 can we merge it?

looks like! (besides that i enjoy open Pull Requests, especially this one)

@ImBIOS
Copy link
Author

ImBIOS commented Dec 30, 2024

hi and thanks! @ImBIOS

@4yman-0 can we merge it?

looks like! (besides that i enjoy open Pull Requests, especially this one)

why not merge it?

@4yman-0
Copy link

4yman-0 commented Dec 30, 2024

why not merge it?

IMO, there is no reason besides conflicts with #2726 (Use PrettierJS and ESLint) which can be EASILY resolved.

Copy link

@4yman-0 4yman-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing some folders and adding build/__pycache__

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants