fix(plugins): rename NoHelmChartTestFailuresCondition to HelmChartTestSucceededCondition

docs/reference/api/openapi.yaml

@@ -1,7 +1,7 @@
 openapi: 3.0.0
 info:
   title: Greenhouse
-  version: 89f438b
+  version: 60a2c5f
   description: PlusOne operations platform
 paths:
   /TeamMembership:

pkg/apis/greenhouse/v1alpha1/plugin_types.go

@@ -67,8 +67,8 @@ const (
 	// StatusUpToDateCondition reflects the failed reconciliation of the Plugin.
 	StatusUpToDateCondition ConditionType = "StatusUpToDate"
 
-	// NoHelmChartTestFailuresCondition reflects the status of the HelmChart tests.
-	NoHelmChartTestFailuresCondition ConditionType = "NoHelmChartTestFailures"
+	// HelmChartTestSucceededCondition reflects the status of the HelmChart tests.
+	HelmChartTestSucceededCondition ConditionType = "HelmChartTestSucceeded"
 
 	// PluginDefinitionNotFoundReason is set when the pluginDefinition is not found.
 	PluginDefinitionNotFoundReason ConditionReason = "PluginDefinitionNotFound"

pkg/controllers/plugin/helm_chart_test_controller.go

@@ -84,11 +84,11 @@ func (r *HelmChartTestReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 
 	pluginStatus := initPluginStatus(plugin)
 
-	noHelmChartTestFailuresCondition := *pluginStatus.GetConditionByType(greenhousev1alpha1.NoHelmChartTestFailuresCondition)
+	HelmChartTestSucceededCondition := *pluginStatus.GetConditionByType(greenhousev1alpha1.HelmChartTestSucceededCondition)
 
 	defer func() {
 		_, err := clientutil.PatchStatus(ctx, r.Client, plugin, func() error {
-			plugin.Status.StatusConditions.SetConditions(noHelmChartTestFailuresCondition)
+			plugin.Status.StatusConditions.SetConditions(HelmChartTestSucceededCondition)
 			return nil
 		})
 		if err != nil {
@@ -119,12 +119,12 @@ func (r *HelmChartTestReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 		"namespace": plugin.Namespace,
 	}
 	if err != nil {
-		noHelmChartTestFailuresCondition.Status = metav1.ConditionFalse
+		HelmChartTestSucceededCondition.Status = metav1.ConditionFalse
 		errStr := fmt.Sprintf("Helm Chart testing failed: %s. To debug, please run `helm test %s`command in your remote cluster %s.", err.Error(), plugin.Name, plugin.Spec.ClusterName)
 		errStr = strings.ReplaceAll(errStr, "\n", "")
 		errStr = strings.ReplaceAll(errStr, "\t", " ")
 		errStr = strings.ReplaceAll(errStr, "*", "")
-		noHelmChartTestFailuresCondition.Message = errStr
+		HelmChartTestSucceededCondition.Message = errStr
 
 		prometheusLabels["result"] = "Error"
 		chartTestRunsTotal.With(prometheusLabels).Inc()
@@ -133,14 +133,14 @@ func (r *HelmChartTestReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 	}
 
 	if !hasHelmChartTest {
-		noHelmChartTestFailuresCondition.Status = metav1.ConditionTrue
-		noHelmChartTestFailuresCondition.Message = "No Helm Chart Tests defined by the PluginDefinition"
+		HelmChartTestSucceededCondition.Status = metav1.ConditionTrue
+		HelmChartTestSucceededCondition.Message = "No Helm Chart Tests defined by the PluginDefinition"
 
 		prometheusLabels["result"] = "NoTests"
 		chartTestRunsTotal.With(prometheusLabels).Inc()
 	} else {
-		noHelmChartTestFailuresCondition.Status = metav1.ConditionTrue
-		noHelmChartTestFailuresCondition.Message = "Helm Chart Test is successful"
+		HelmChartTestSucceededCondition.Status = metav1.ConditionTrue
+		HelmChartTestSucceededCondition.Message = "Helm Chart Test is successful"
 
 		prometheusLabels["result"] = "Success"
 		chartTestRunsTotal.With(prometheusLabels).Inc()

pkg/controllers/plugin/util.go

@@ -34,7 +34,7 @@ var exposedConditions = []greenhousev1alpha1.ConditionType{
 	greenhousev1alpha1.HelmDriftDetectedCondition,
 	greenhousev1alpha1.HelmReconcileFailedCondition,
 	greenhousev1alpha1.StatusUpToDateCondition,
-	greenhousev1alpha1.NoHelmChartTestFailuresCondition,
+	greenhousev1alpha1.HelmChartTestSucceededCondition,
 	greenhousev1alpha1.WorkloadReadyCondition,
 }
 
@@ -272,7 +272,7 @@ func computeReadyCondition(
 		readyCondition.Message = "Helm reconcile failed"
 		return readyCondition
 	}
-	if conditions.GetConditionByType(greenhousev1alpha1.NoHelmChartTestFailuresCondition).IsFalse() {
+	if conditions.GetConditionByType(greenhousev1alpha1.HelmChartTestSucceededCondition).IsFalse() {
 		readyCondition.Status = metav1.ConditionFalse
 		readyCondition.Message = "Helm Chart Test failed"
 		return readyCondition