fix(plugins): rename NoHelmChartTestFailuresCondition to HelmChartTestSucceededCondition

[ibakshay]

The current status condition NoHelmChartTestFailures uses a double negative that makes it difficult to understand at a glance. Based on user feedback, we're renaming it to be more intuitive and direct.

This change makes the status condition:

• More straightforward to interpret
• Easier to understand without having to process double negatives

The functionality remains the same - the condition indicates whether the Helm chart tests is executed successfully.

Signed-off-by: Akshay Iyyadurai Balasundaram [email protected]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

• 🍕 Feature
• 🐛 Bug Fix
• 📝 Documentation Update
• 🎨 Style
• 🧑‍💻 Code Refactor
• 🔥 Performance Improvements
• ✅ Test
• 🤖 Build
• 🔁 CI
• 📦 Chore (Release)
• ⏩ Revert

Related Tickets & Documents

• Related Issue # (issue)
• Closes # (issue)
• Fixes # (issue)

Remove if not applicable

Added tests?

• 👍 yes
• 🙅 no, because they aren't needed
• 🙋 no, because I need help
• Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

• 📜 README.md
• 🤝 Documentation pages updated
• 🙅 no documentation needed
• (if applicable) generated OpenAPI docs for CRD changes

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[IvoGoman]

This will add the new HelmChartTestSucceeded condition to the status of a Plugin. However, the existing condition will not be removed. To avoid manual patching of the existing Plugins, I would suggest removing the old condition via the controller first. Once this is rolled out, the logic can be removed again.

[ibakshay]

This will add the new HelmChartTestSucceeded condition to the status of a Plugin. However, the existing condition will not be removed. To avoid manual patching of the existing Plugins, I would suggest removing the old condition via the controller first. Once this is rolled out, the logic can be removed again.

This is a great suggestion. I have done as you have suggested and I have also added some tests :)
Ref: 862427e

[IvoGoman]

I have tracked the removal of the deprecated Condition here: #754

[ibakshay]

@IvoGoman Why does the CI and other GHA workflows have not run for this PR?

[IvoGoman]

@IvoGoman Why does the CI and other GHA workflows have not run for this PR?

This is a feature of Github Action, and should be fixed with #756. TL;DR; only when using a PAT a commit will trigger the workflows.

[ibakshay]

@IvoGoman Why does the CI and other GHA workflows have not run for this PR?

This is a feature of Github Action, and should be fixed with #756. TL;DR; only when using a PAT a commit will trigger the workflows.

Ah I see..
So, there wont be CI trigger when there is a commit to generate the CRD API Docs?
So, that means I am good to merge this PR, right?

[IvoGoman]

@IvoGoman Why does the CI and other GHA workflows have not run for this PR?

This is a feature of Github Action, and should be fixed with #756. TL;DR; only when using a PAT a commit will trigger the workflows.

Ah I see.. So, there wont be CI trigger when there is a commit to generate the CRD API Docs? So, that means I am good to merge this PR, right?

There is still a linter issue open: https://github.com/cloudoperators/greenhouse/actions/runs/11897250768/job/33189959724#step:4:205

[abhijith-darshan]

@IvoGoman Why does the CI and other GHA workflows have not run for this PR?

This is a feature of Github Action, and should be fixed with #756. TL;DR; only when using a PAT a commit will trigger the workflows.

Ah I see.. So, there wont be CI trigger when there is a commit to generate the CRD API Docs? So, that means I am good to merge this PR, right?

You can see the status check for the commit before CRD API commit where the checks are failing.