Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(teamrolebindings): team role binding controller standardization #667

Merged
merged 18 commits into from
Nov 12, 2024

Conversation

Zaggy21
Copy link
Contributor

@Zaggy21 Zaggy21 commented Oct 25, 2024

Description

Implemented standardized interface for TeamRoleBinding controller. Added messages with relevant information to PropagationStatus of RoleBinding.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

I've added conditions checks to a TeamRoleBinding test. I've added a test checking that the error is propagated correctly when non-existing namespace was specified.

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Zaggy21 Zaggy21 requested a review from a team as a code owner October 25, 2024 10:11
@Zaggy21 Zaggy21 linked an issue Oct 25, 2024 that may be closed by this pull request
3 tasks
@Zaggy21 Zaggy21 changed the title refac: teamrolebinding standardization refactor(teamrolebindings): controller standardization Nov 6, 2024
@Zaggy21 Zaggy21 requested a review from IvoGoman November 6, 2024 15:26
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 7, 2024
@Zaggy21 Zaggy21 changed the title refactor(teamrolebindings): controller standardization refactor(teamrolebindings): team role binding controller standardization Nov 12, 2024
@Zaggy21 Zaggy21 merged commit 0835c21 into main Nov 12, 2024
2 checks passed
@Zaggy21 Zaggy21 deleted the refac/teamrolebinding_standardization branch November 12, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-apis documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFAC] - Standardise TeamRoleBindingController
2 participants