Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFAC] - Standardise TeamRoleBindingController #581

Closed
3 tasks
Tracked by #544
IvoGoman opened this issue Sep 17, 2024 · 1 comment · Fixed by #667
Closed
3 tasks
Tracked by #544

[REFAC] - Standardise TeamRoleBindingController #581

IvoGoman opened this issue Sep 17, 2024 · 1 comment · Fixed by #667
Assignees

Comments

@IvoGoman
Copy link
Contributor

IvoGoman commented Sep 17, 2024

As part of the standardisation of the reconciliation loop for Greenhouse controllers, this controller needs to be updated to follow the common recommendation for the Reconciliation

Acceptance Criteria

  • Implement the Interface
  • Use the standardised patch for updating the status instead of the deferred update (if applicable)
  • Convert the tests to use test.TestSetup (if applicable) including creation of missing resources
@github-project-automation github-project-automation bot moved this to Sprint Backlog in Greenhouse Core Roadmap Sep 17, 2024
@IvoGoman IvoGoman moved this from Sprint Backlog to Todo in Greenhouse Core Roadmap Sep 17, 2024
@IvoGoman IvoGoman changed the title [FEAT] - Standardise TeamRoleBindingController [REFAC] - Standardise TeamRoleBindingController Sep 17, 2024
@IvoGoman
Copy link
Contributor Author

Propagate the error correctly while reconciling a TeamRoleBinding with namespaces where a non-existing Namespace was specified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants