Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly reduce dependency. #1969

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Jul 18, 2023

No need to depend on full protobuf, just the io part is what we're interested in.

No need to depend on full protobuf, just the io part is what we're
interested in.
@hzeller hzeller requested a review from ivan444 July 18, 2023 19:03
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (167f23d) 92.85% compared to head (8340234) 92.85%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1969   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files         355      355           
  Lines       26272    26272           
=======================================
  Hits        24395    24395           
  Misses       1877     1877           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hzeller
Copy link
Collaborator Author

hzeller commented Jul 18, 2023

... saves about 170 processes run by bazel. Small amount, but also worthwhile to be specific.

@hzeller hzeller merged commit 18b819f into chipsalliance:master Jul 18, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants