Use clang-tidy action to push comments to the PR.

.github/workflows/clang-tidy-post-comment.yml

@@ -0,0 +1,14 @@
+name: Post clang-tidy review comments
+
+on:
+  workflow_run:
+    # The name field of the lint action .github/workflows/clang-tidy-run.yml
+    workflows: ["clang-tidy-review"]
+    types:
+      - completed
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: ZedThree/clang-tidy-review/[email protected]

.github/workflows/clang-tidy-run.yml

@@ -0,0 +1,43 @@
+name: clang-tidy-review
+
+on:
+  pull_request:
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Create Cache Timestamp
+        id: cache_timestamp
+        uses: nanzm/[email protected]
+        with:
+          format: 'YYYY-MM-DD-HH-mm-ss'
+
+      - name: Retrieve cached results
+        uses: actions/cache@v3
+        with:
+          path: |
+            /root/.cache/clang-tidy
+            /root/.cache/bazel
+            key: clang-tidy-${{ steps.cache_timestamp.outputs.time }}
+            restore-keys: clang-tidy-
+
+      - name: Make compilation DB
+        run: |
+          export USE_BAZEL_VERSION=6.5.0
+          .github/bin/make-compilation-db.sh
+
+      - name: Create clang-tidy review
+        id: clang-tidy-review
+        uses: ZedThree/[email protected]
+        with:
+          split_workflow: true    # Post comments separately
+          clang_tidy_version: 17
+          config_file: .clang-tidy
+
+      - uses: ZedThree/clang-tidy-review/[email protected]

common/strings/obfuscator.cc

@@ -54,6 +54,8 @@ std::string Obfuscator::save() const {
 absl::Status Obfuscator::load(absl::string_view mapping) {
   const std::vector<absl::string_view> lines =
       absl::StrSplit(mapping, '\n', absl::SkipEmpty());
+  BijectiveMap<std::string, std::string, StringViewCompare, StringViewCompare>
+      footesting;
   for (const auto &line : lines) {
     const std::vector<absl::string_view> elements =
         absl::StrSplit(absl::StripAsciiWhitespace(line), kPairSeparator);