Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Multi-dimensional operational domain computation #493

Merged
merged 122 commits into from
Aug 21, 2024

Merge branch 'main' into opdomain-explorer-additions

e57edd4
Select commit
Loading
Failed to load commit list.
Merged

✨ Multi-dimensional operational domain computation #493

Merge branch 'main' into opdomain-explorer-additions
e57edd4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 21, 2024 in 1s

98.16% (target 95.00%)

View this Pull Request on Codecov

98.16% (target 95.00%)

Details

Codecov Report

Attention: Patch coverage is 95.06329% with 39 lines in your changes missing coverage. Please review.

Project coverage is 98.16%. Comparing base (246bb8d) to head (e57edd4).
Report is 1 commits behind head on main.

Files Patch % Lines
.../algorithms/simulation/sidb/operational_domain.hpp 92.39% 21 Missing ⚠️
include/fiction/io/write_operational_domain.hpp 66.66% 7 Missing ⚠️
.../algorithms/simulation/sidb/operational_domain.cpp 97.74% 6 Missing ⚠️
...ion/sidb/determine_physically_valid_parameters.cpp 96.00% 3 Missing ⚠️
include/fiction/io/print_layout.hpp 71.42% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   98.21%   98.16%   -0.06%     
==========================================
  Files         224      224              
  Lines       30554    31042     +488     
  Branches     1505     1549      +44     
==========================================
+ Hits        30008    30471     +463     
- Misses        546      571      +25     
Files Coverage Δ
...ude/fiction/algorithms/iter/bdl_input_iterator.hpp 100.00% <100.00%> (ø)
...ion/sidb/determine_physically_valid_parameters.hpp 100.00% <100.00%> (ø)
...simulation/sidb/displacement_robustness_domain.hpp 97.53% <100.00%> (-0.15%) ⬇️
...tion/algorithms/simulation/sidb/is_operational.hpp 93.25% <ø> (ø)
include/fiction/utils/hash.hpp 100.00% <ø> (ø)
include/fiction/utils/layout_utils.hpp 98.99% <ø> (ø)
include/fiction/utils/math_utils.hpp 100.00% <100.00%> (ø)
test/algorithms/iter/bdl_input_iterator.cpp 97.29% <100.00%> (+0.11%) ⬆️
test/algorithms/mockturtle.cpp 100.00% <ø> (ø)
...lgorithms/simulation/sidb/critical_temperature.cpp 100.00% <ø> (ø)
... and 7 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d18ead1...e57edd4. Read the comment docs.