Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Multi-dimensional operational domain computation #493

Merged
merged 122 commits into from
Aug 21, 2024
Merged

✨ Multi-dimensional operational domain computation #493

merged 122 commits into from
Aug 21, 2024

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Aug 8, 2024 •
edited
Loading

Description

This PR mainly introduces multi-dimensional operational domain computation. That is, it provides a framework for performing physical simulations over arbitrary sweep dimensions. Currently, the dimensions epsilon_r, lambda_tf, and mu_minus are supported, but new ones can be added easily.

This PR also incorporates various performance improvements, particularly concerning multithreading in operational domain computation. To this end, it abandons the previously utilized C++ execution policies in favor of manual thread management. This not only makes the code less platform-dependent and offers increased performance in the Python bindings, but it also enables us to tweak load-balancing, particularly for grid search, which is now really fast given sufficient CPU cores.

Grid search and random sampling support true multi-dimensional operational domain sweeps. Flood fill supports two- and three-dimensional sweeps. Contour tracing is limited to two dimensions by design.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

marcelwa and others added 30 commits April 22, 2024 18:49
@marcelwa
✨ Added I/O coloring to SiDB layout printing
3507e07
@marcelwa
Merge branch 'refs/heads/main' into opdomain-explorer-additions
f0ec553
@marcelwa
🎨 Changed the default operational/non-operational tags to 1 and 0
744f58c
@marcelwa
🎨 Small changes
edee07f
@marcelwa
Merge branch 'refs/heads/main' into opdomain-explorer-additions
2bf056f
@actions-user
📝 Update pyfiction docstrings
0e19a75 
Signed-off-by: GitHub Actions <[email protected]>
@marcelwa
💩 Save commit, stuff doesn't work yet
69eb8f1
@marcelwa
✨ Exposed bdl_input_iterator in pyfiction
2dc2bf8
@marcelwa
📝 Added RST documentation
7afa443
@marcelwa
Merge remote-tracking branch 'origin/opdomain-explorer-additions' int…
dbb29ff 
…o opdomain-explorer-additions
@actions-user
📝 Update pyfiction docstrings
76ba036 
Signed-off-by: GitHub Actions <[email protected]>
@marcelwa
🧵 First attempt to port grid search from execution policies to manual…
a2c0a45 
… threading
@marcelwa
Merge remote-tracking branch 'origin/opdomain-explorer-additions' int…
9b56f49 
…o opdomain-explorer-additions
@marcelwa
🔀 Merge
6355dcf
@marcelwa
🧵 Rewrite random_sampling in operational_domain.hpp to use `std::…
afe01f2 
…thread`s instead of execution policies
@actions-user
📝 Update pyfiction docstrings
e97e833 
Signed-off-by: GitHub Actions <[email protected]>
@marcelwa
🎨 Reduced code duplication; more work can be done here in grid_search
99a43c7
@marcelwa
Merge remote-tracking branch 'origin/opdomain-explorer-additions' int…
fe72795 
…o opdomain-explorer-additions
@actions-user
📝 Update pyfiction docstrings
01a0013 
Signed-off-by: GitHub Actions <[email protected]>
@marcelwa
✨ Introduce n-dimensional operational domain computation (needs testing)
f3d507e
@marcelwa
Merge remote-tracking branch 'origin/opdomain-explorer-additions' int…
8f5e479 
…o opdomain-explorer-additions
@actions-user
📝 Update pyfiction docstrings
73f6cca 
Signed-off-by: GitHub Actions <[email protected]>
@marcelwa
🎨 Small code clean up
efaa081
@marcelwa
Merge remote-tracking branch 'origin/opdomain-explorer-additions' int…
b23aef4 
…o opdomain-explorer-additions
@marcelwa
✨ Added 3D Moore neighborhood
5326399
@marcelwa
✅ Added test cases for 3-dimensional operational domain computation
f0b2890
@marcelwa
✨ Support n-dimensional operational domains in `write_operational_dom…
4b13e7f 
…ain`
@actions-user
📝 Update pyfiction docstrings
27d06bc 
Signed-off-by: GitHub Actions <[email protected]>
@marcelwa
Merge branch 'refs/heads/main' into opdomain-explorer-additions
a4c69ee 
# Conflicts:
#	libs/mockturtle
#	libs/pybind11
@marcelwa
✨ Support n-dimensional operational domains in experiments
6352489
marcelwa and others added 12 commits August 19, 2024 19:21
@marcelwa
🐍 Updated pyfiction docstrings with regard to operational domain comp…
5357338 
…utation changes
@actions-user
📝 Update pyfiction docstrings
2b9f60f 
Signed-off-by: GitHub Actions <[email protected]>
@marcelwa
📝 Fixed Python documentation for bdl_input_iterator
278cf4b
@marcelwa
Merge remote-tracking branch 'origin/opdomain-explorer-additions' int…
0e88d45 
…o opdomain-explorer-additions
@marcelwa
🎨 Removed unused include
193e273
@marcelwa
🎨 Moved contains_parameter_point and find_key_with_tolerance to t…
05ff17e 
…he `detail` namespace
@actions-user
📝 Update pyfiction docstrings
e1f608a 
Signed-off-by: GitHub Actions <[email protected]>
@marcelwa
🐛 Added missing forward-declaration to fix compiler error
bfb5765
@marcelwa
Merge remote-tracking branch 'origin/opdomain-explorer-additions' int…
54ca3e2 
…o opdomain-explorer-additions
@actions-user
📝 Update pyfiction docstrings
3eb8e38 
Signed-off-by: GitHub Actions <[email protected]>
@marcelwa
🐛 Fixed compiler error in determine_physically_valid_parameters
91f95de
@marcelwa
Merge remote-tracking branch 'origin/opdomain-explorer-additions' int…
abdb2c2 
…o opdomain-explorer-additions
@marcelwa marcelwa requested a review from Drewniok August 19, 2024 21:43
@Drewniok
Copy link
Collaborator

@marcelwa many thanks! I assume the CLI issue is fixed, right?

@marcelwa
Copy link
Collaborator Author

@marcelwa many thanks! I assume the CLI issue is fixed, right?

Ah right, I forgot to mention that. Unfortunately, I just couldn't find the source of the problem there 😕 the error occurs when you pass parameter ranges to the CLI where the min value is larger than the max value. On first try, the correct error handling is triggered. When you pass the exact same command a second time, no error handling happens (and I think OpDom is executed with default parameters). Next time, the error handling is triggered again, and so forth.

@Drewniok
Copy link
Collaborator

Drewniok commented Aug 20, 2024 •
edited
Loading

@marcelwa many thanks! I assume the CLI issue is fixed, right?

Ah right, I forgot to mention that. Unfortunately, I just couldn't find the source of the problem there 😕 the error occurs when you pass parameter ranges to the CLI where the min value is larger than the max value. On first try, the correct error handling is triggered. When you pass the exact same command a second time, no error handling happens (and I think OpDom is executed with default parameters). Next time, the error handling is triggered again, and so forth.

okay, that's a pity. Should we then leave a comment in cli/op_domain for future reference?

@marcelwa
Copy link
Collaborator Author

@marcelwa many thanks! I assume the CLI issue is fixed, right?

Ah right, I forgot to mention that. Unfortunately, I just couldn't find the source of the problem there 😕 the error occurs when you pass parameter ranges to the CLI where the min value is larger than the max value. On first try, the correct error handling is triggered. When you pass the exact same command a second time, no error handling happens (and I think OpDom is executed with default parameters). Next time, the error handling is triggered again, and so forth.

okay, that's a pity. Should we then leave a comment in cli/op_domain for future reference?

That's a good idea. Thanks!

@marcelwa marcelwa requested a review from Drewniok August 20, 2024 12:35
@marcelwa marcelwa requested a review from Drewniok August 20, 2024 17:48
Drewniok
Drewniok approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@Drewniok Drewniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many, many thanks for your hard work and this new set of algorithms!

@marcelwa marcelwa merged commit b213292 into main Aug 21, 2024
61 checks passed
@marcelwa marcelwa deleted the opdomain-explorer-additions branch August 21, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drewniok Drewniok Drewniok approved these changes

Assignees

@marcelwa marcelwa

Labels
enhancement New feature or request performance Performance improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelwa @Drewniok @actions-user