Add option for requester pays into joint genotyper (import gvcf) #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
samuelklee
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Thanks @yfarjoun. Looks fine to me, but could you fix up the typo in the commit message (requestor -> requester) and perhaps tidy it up?
I don't think any changelog updates are required for changes to tasks, but perhaps the second reviewer can confirm---I'm still a bit new to this repo.
yfarjoun
changed the title
|
test this please |
|
add to whitelist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables the user to specify the google-project that should be used for accessing requester-pays files when reading gVCFs into VariantDB.