New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daklapack Bulk Order Validation #101

Open

colts661 wants to merge 5 commits into biocore:master from colts661:master

Contributor

colts661 commented Apr 24, 2024 •

edited

Loading

Fixed #100

Added validation to Daklapack order addresses before submitting to Daklapack:

Empty rows are disregarded
Rows with incomplete information are hold from private API call
- Only insertion, address2 can be empty
- These rows are reflected in the output
A private API call will not be made if there is no complete address in the file

Added tests in tests/test_route.py:

Adjusted the original test_post_submit_daklapack_order_success since it covers the optional fields condition
Added test_post_submit_daklapack_order_hold that will not make a private API call

colts661 and others added 5 commits

April 22, 2024 21:50


Added Bulk Daklapack Order Verification

4fd877c


Fixed style

95a56c9


Display missing fields

2949a2e


Add tests


Merge branch 'biocore:master' into master

c4a0ba0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment