Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank Spreadsheet Rows on Daklapack Bulk Order #100

Open
cassidysymons opened this issue Apr 1, 2024 · 0 comments · May be fixed by #101
Open

Blank Spreadsheet Rows on Daklapack Bulk Order #100

cassidysymons opened this issue Apr 1, 2024 · 0 comments · May be fixed by #101

Comments

@cassidysymons
Copy link
Collaborator

I just observed an issue where blank rows in a spreadsheet used to place a bulk order with Daklapack were treated as data and our system attempted to place empty orders through Daklapack's API. When I open the XLS file, I see two rows - the header, and a single address. However, when I convert the XLS file to CSV, it renders as follows (with most of the actual values redacted):

firstName,lastName,address1,insertion,address2,postalCode,city,state,country,countryCode
[REDACTED FIRST NAME],[REDACTED LAST NAME],[REDACTED ADDRESS1],,[REDACTED ADDRESS 2],[REDACTED ZIP],[REDACTED CITY],CA,USA,us
,,,,,,,,,
,,,,,,,,,
,,,,,,,,,
,,,,,,,,,
,,,,,,,,,
,,,,,,,,,
,,,,,,,,,
,,,,,,,,,
,,,,,,,,,
,,,,,,,,,
,,,,,,,,,

When our system processed the file for ordering, it returned one success message for the row with actual values, then 11 validation errors from the Daklapack API for the empty rows.

While this is largely an issue with Excel functioning counterintuitively, it would be good to enforce very basic validation before attempting to place a bulk order with Daklapack, such as making sure all required fields are present. If a row is entirely empty, silently discarding the row would be fine. Otherwise, warning the user without attempting to contact Daklapack's API for that row would be appropriate.

@colts661 colts661 linked a pull request Apr 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant