Skip to content

Commit

Permalink
Fixup: PR 811: install an upper-bounded version of Jinja2 during docu…
Browse files Browse the repository at this point in the history
…mentation build (#812)

* BUG: Fixes issue with Pandas >=1.5

Set objects are no longer allowed as an index argument for a DataFrame
constructor.

Fixes #810

* ENH: Use newer version of node

* (Re)install a semver-upper-bounded version of jinja2 package dependency during sphinx documentation build

Ref: pallets/jinja#1630

Ref: sphinx-doc/sphinx#10291

* Revert "(Re)install a semver-upper-bounded version of jinja2 package dependency during sphinx documentation build"

This reverts commit de26d4d.

* Specify semver-upper-bounded version of jinja2 package-documentation dependency

Follows-on-from commit de26d4d.

* Fixup: flake8-acceptable formatting for setup.py

* Update ChangeLog.md

Co-authored-by: Yoshiki Vázquez Baeza <[email protected]>
  • Loading branch information
jayaddison and ElDeveloper committed Jan 26, 2023
1 parent 851154e commit 6163b4e
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Set up Node.js enviroment
uses: actions/setup-node@v1
with:
node-version: 14
node-version: 16

- uses: conda-incubator/setup-miniconda@v2
with:
Expand Down
4 changes: 3 additions & 1 deletion ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Emperor ChangeLog
### Bug Fixes

* Update remote URL to no longer use rawgit.
([#751(https://github.com/biocore/emperor/issues/751)]).
([#751](https://github.com/biocore/emperor/issues/751)).

### New Features

Expand All @@ -16,6 +16,8 @@ Emperor ChangeLog

* Pin Sphinx version to be less than 4.0.
* Jupyter templates no longer require jQuery to add the CSS headers.
* Fix broken test suite with Pandas >=1.5 ([#810](https://github.com/biocore/emperor/issues/810)).
* Limit jinja2 version for doc dependencies in setup.py. Allowed versions are: `>=2.9` and `<3.1`.

# Emperor 1.0.3 (14 Apr 2021)
-----------------------------
Expand Down
4 changes: 2 additions & 2 deletions emperor/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,9 @@ def _validate_metadata(self, metadata, matrix, ignore_missing_samples,
'are using metadata and coordinates corresponding'
' to the same dataset.' % kind)

# sort the elements so we have a deterministic output
difference = sorted([str(i) for i in difference])
if difference and not ignore_missing_samples:
# sort the elements so we have a deterministic output
difference = sorted([str(i) for i in difference])

# if there's more than 5 missing elements, truncate the list
if len(difference) > 5:
Expand Down
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@

base = ["numpy >= 1.7", "scipy >= 0.17.0", "click", "pandas",
"scikit-bio >= 0.4.1", "jinja2 >= 2.9", "future"]
doc = ["Sphinx<4", "sphinx-bootstrap-theme", "numpydoc"]
doc = ["Sphinx<4", "jinja2 >= 2.9, < 3.1", "sphinx-bootstrap-theme",
"numpydoc"]
test = ["pep8", "flake8", "nose"]
all_deps = base + doc + test

Expand Down

0 comments on commit 6163b4e

Please sign in to comment.