Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Webpack configuration for external Flickity dependency to fix require issues on Linux #94

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+76 −8
Open

Change Webpack configuration for external Flickity dependency to fix require issues on Linux #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0fd8b4b
Add Node template to gitignore file to exclude coverage folder and np…
Mar 13, 2018
c312574
Add cross-env to set environment variable across different systems (i…
Mar 13, 2018
6c13164
Split up externals in Webpack configuration to use capital letter whe…
Mar 13, 2018
76a0e74
Add generated files after build
Mar 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 63 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,66 @@
.DS_Store
node_modules
.idea

### Node template
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Bower dependency directory (https://bower.io/)
bower_components

# node-waf configuration
.lock-wscript

# Compiled binary addons (https://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules/
jspm_packages/

# Typescript v1 declaration files
typings/

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity

# dotenv environment variables file
.env

# next.js build output
.next

8 changes: 4 additions & 4 deletions dist/angular-flickity.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/angular-flickity.min.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
],
"main": "dist/angular-flickity.js",
"scripts": {
"build": "WEBPACK_ENV=build webpack && osx-notifier --type \"pass\" --title \"Build successful\" --message \"gg\" --group \"npmBuild\"",
"build": "cross-env WEBPACK_ENV=build webpack && osx-notifier --type \"pass\" --title \"Build successful\" --message \"gg\" --group \"npmBuild\"",
"watch": "npm run build && onchange 'src/**/*.js' -- npm run build",
"test": "karma start --singleRun=true",
"watch:tests": "karma start"
Expand All @@ -44,6 +44,7 @@
"babel-loader": "6.1.0",
"babel-plugin-add-module-exports": "0.1.2",
"babel-preset-es2015": "6.3.13",
"cross-env": "^5.1.4",
"eslint": "^3.8.1",
"eslint-config-moment": "^2.1.4",
"eslint-loader": "^1.6.1",
Expand Down
7 changes: 6 additions & 1 deletion webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ const config = {
umdNamedDefine: true,
},
externals: {
'flickity': 'Flickity',
flickity: {
commonjs: 'flickity',
commonjs2: 'flickity',
amd: 'flickity',
root: 'Flickity',
},
},
module: {
preLoaders: [
Expand Down