Change Webpack configuration for external Flickity dependency to fix require issues on Linux #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 13, 2018 16:23
…m debug logs and add .idea folder to exclude IntelliJ specific files
…ncluding Windows) to fix building issues on Windows
…n dealing with root and lowercase module name when dealing with modules to fix require issues on Linux based systems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! This fixes #87. I used my local Git username instead of my Github username by accident, but it's me :)
I also added the use of the cross-env dependency, since the environment variables weren't being set correctly in the build script on my Windows machine.
I also added the Node *.gitignore template to not include the "coverage" folder and also excluded the ".idea" for Intellij users.