Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Remove STOP_PROPAGATION define. #55582

Closed
wants to merge 1 commit into from
Closed

refactor(core): Remove STOP_PROPAGATION define. #55582

wants to merge 1 commit into from

Conversation

tbondwilkinson
Copy link
Contributor

This define has been removed at head, and now legacy stop propagation behavior can be opted into at the LegacyDispatcher level, if necessary.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Stop propagation define exists

Issue Number: N/A

What is the new behavior?

Stop propagation define does not exist

Does this PR introduce a breaking change?

  • Yes
  • No

@tbondwilkinson tbondwilkinson marked this pull request as ready for review April 30, 2024 15:39
@pullapprove pullapprove bot requested a review from alxhub April 30, 2024 15:39
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Apr 30, 2024
@tbondwilkinson tbondwilkinson requested review from AndrewKushnir and removed request for alxhub April 30, 2024 15:39
@tbondwilkinson tbondwilkinson added the area: core Issues related to the framework runtime label Apr 30, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 30, 2024
@tbondwilkinson tbondwilkinson added core: event dispatch target: minor This PR is targeted for the next minor release action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 30, 2024
@AndrewKushnir
Copy link
Contributor

@tbondwilkinson it looks like a golden file needs an update as well (CI fails because of this). Could you please run yarn bazel run //packages/core:core_api.accept and add an updated golden file to the commit?

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 30, 2024
@tbondwilkinson
refactor(core): Remove STOP_PROPAGATION define.
cdd9479 
This define has been removed at head, and now legacy stop propagation
behavior can be opted into at the LegacyDispatcher level, if necessary.
@tbondwilkinson
Copy link
Contributor Author

@tbondwilkinson it looks like a golden file needs an update as well (CI fails because of this). Could you please run yarn bazel run //packages/core:core_api.accept and add an updated golden file to the commit?

Done

AndrewKushnir
AndrewKushnir approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from atscott April 30, 2024 16:40
@AndrewKushnir AndrewKushnir requested review from thePunderWoman and removed request for atscott April 30, 2024 16:40
@tbondwilkinson
Copy link
Contributor Author

tbondwilkinson commented Apr 30, 2024 •
edited

Caretaker note: cl/629158001 necessary to submit prior to sync CL to fix up copybara patches

thePunderWoman
thePunderWoman approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: primitives, public-api

@tbondwilkinson
Copy link
Contributor Author

TESTED=TGP

@tbondwilkinson tbondwilkinson added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels May 1, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit b9a997c.

tbondwilkinson added a commit to tbondwilkinson/angular that referenced this pull request May 1, 2024
@tbondwilkinson
refactor(core): Remove STOP_PROPAGATION define. (angular#55582)
d3d43db 
This define has been removed at head, and now legacy stop propagation
behavior can be opted into at the LegacyDispatcher level, if necessary.

PR Close angular#55582
AndrewKushnir pushed a commit that referenced this pull request May 1, 2024
@tbondwilkinson @AndrewKushnir
refactor(core): Remove STOP_PROPAGATION define. (#55582) (#55621)
7dce62b 
This define has been removed at head, and now legacy stop propagation
behavior can be opted into at the LegacyDispatcher level, if necessary.

PR Close #55582

PR Close #55621
@tbondwilkinson tbondwilkinson deleted the jsaction-stop-propagation branch May 6, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@rahatarmanahmed rahatarmanahmed rahatarmanahmed approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: event dispatch merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note requires: TGP This PR requires a passing TGP before merging is allowed target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tbondwilkinson @AndrewKushnir @thePunderWoman @rahatarmanahmed