Skip to content

Commit

Permalink
refactor(core): Remove STOP_PROPAGATION define. (#55582)
Browse files Browse the repository at this point in the history
This define has been removed at head, and now legacy stop propagation
behavior can be opted into at the LegacyDispatcher level, if necessary.

PR Close #55582
  • Loading branch information
tbondwilkinson authored and AndrewKushnir committed May 1, 2024
1 parent 5903c37 commit b9a997c
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 13 deletions.
2 changes: 0 additions & 2 deletions goldens/public-api/core/primitives/event-dispatch/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ export class EventContract implements UnrenamedEventContract {
static MOUSE_SPECIAL_SUPPORT: boolean;
registerDispatcher(dispatcher: Dispatcher_2, restriction: Restriction): void;
replayEarlyEvents(): void;
// (undocumented)
static STOP_PROPAGATION: boolean;
}

// @public
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,6 @@ export const A11Y_CLICK_SUPPORT = false;
*/
export const MOUSE_SPECIAL_SUPPORT = false;

/**
* @define Call stopPropagation on handled events. When integrating with
* non-jsaction event handler based code, you will likely want to turn this flag
* off. While most event handlers will continue to work, jsaction binds focus
* and blur events in the capture phase and thus with stopPropagation, none of
* your non-jsaction-handlers will ever see it.
*/
export const STOP_PROPAGATION = true;

/**
* @define Support for custom events, which are type EventType.CUSTOM. These are
* native DOM events with an additional type field and an optional payload.
Expand Down
2 changes: 0 additions & 2 deletions packages/core/primitives/event-dispatch/src/eventcontract.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ import {
CUSTOM_EVENT_SUPPORT,
JSNAMESPACE_SUPPORT,
MOUSE_SPECIAL_SUPPORT,
STOP_PROPAGATION,
} from './event_contract_defines';
import * as eventInfoLib from './event_info';
import {EventType} from './event_type';
Expand Down Expand Up @@ -90,7 +89,6 @@ type EventHandler = (eventType: string, event: Event, container: Element) => voi
*/
export class EventContract implements UnrenamedEventContract {
static CUSTOM_EVENT_SUPPORT = CUSTOM_EVENT_SUPPORT;
static STOP_PROPAGATION = STOP_PROPAGATION;
static A11Y_CLICK_SUPPORT = A11Y_CLICK_SUPPORT;
static MOUSE_SPECIAL_SUPPORT = MOUSE_SPECIAL_SUPPORT;
static JSNAMESPACE_SUPPORT = JSNAMESPACE_SUPPORT;
Expand Down

0 comments on commit b9a997c

Please sign in to comment.