Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): consistent-component-styles #1710

Merged
Merged
16 changes: 9 additions & 7 deletions .github/workflows/ci.yml
Expand Up @@ -36,7 +36,7 @@ jobs:
echo "NX_CI_EXECUTION_ENV=Node $(node --version) -" >> $GITHUB_ENV

- name: Start Nx Cloud CI Run
run: npx nx-cloud start-ci-run --distributes-on="6 custom-linux-medium-plus-js"
run: npx nx-cloud start-ci-run --distributes-on="6 custom-linux-medium-plus-js" --stop-agents-after="e2e-suite"

- uses: actions/cache@v4
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
Expand All @@ -57,12 +57,14 @@ jobs:
with:
# Note that the typecheck target *also* typechecks tests and tools,
# whereas the build only checks src files
cmd1: yarn nx run-many -t build,typecheck,check-rule-docs,lint
cmd2: yarn nx run-many -t test --codeCoverage
cmd3: yarn nx-cloud record -- yarn lint
cmd4: yarn nx-cloud record -- yarn format-check
# Run distributed e2e test suites with independent local registries (max 1 per agent via parallel=1)
cmd5: yarn nx run-many -t e2e-suite --parallel 1
cmd1: npx nx run-many -t build,typecheck,check-rule-docs,lint
cmd2: npx nx run-many -t test --codeCoverage
cmd3: npx nx-cloud record -- yarn lint
cmd4: npx nx-cloud record -- yarn format-check

# Run distributed e2e test suites with independent local registries (max 1 per agent via parallel=1)
- name: Run e2e test suites
run: npx nx run-many -t e2e-suite --parallel 1

- name: Publish code coverage report
uses: codecov/codecov-action@v4
Expand Down
1 change: 1 addition & 0 deletions packages/eslint-plugin/README.md
Expand Up @@ -43,6 +43,7 @@
| [`component-class-suffix`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/component-class-suffix.md) | Classes decorated with @Component must have suffix "Component" (or custom) in their name. See more at https://angular.io/styleguide#style-02-03 | :white_check_mark: | | |
| [`component-max-inline-declarations`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/component-max-inline-declarations.md) | Enforces a maximum number of lines in inline template, styles and animations. See more at https://angular.io/guide/styleguide#style-05-04 | | | |
| [`component-selector`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/component-selector.md) | Component selectors should follow given naming rules. See more at https://angular.io/guide/styleguide#style-02-07, https://angular.io/guide/styleguide#style-05-02 and https://angular.io/guide/styleguide#style-05-03. | | | |
| [`consistent-component-styles`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/consistent-component-styles.md) | Ensures component `styles`/`styleUrl` with `string` is used over `styles`/`styleUrls` when there is only a single string in the array | | :wrench: | |
| [`contextual-decorator`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/contextual-decorator.md) | Ensures that classes use contextual decorators in its body | | | |
| [`directive-class-suffix`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/directive-class-suffix.md) | Classes decorated with @Directive must have suffix "Directive" (or custom) in their name. See more at https://angular.io/styleguide#style-02-03 | :white_check_mark: | | |
| [`directive-selector`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/directive-selector.md) | Directive selectors should follow given naming rules. See more at https://angular.io/guide/styleguide#style-02-06 and https://angular.io/guide/styleguide#style-02-08. | | | |
Expand Down