New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): consistent-component-styles #1710
feat(eslint-plugin): consistent-component-styles #1710
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 761f435. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 7 targetsSent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1710 +/- ##
==========================================
+ Coverage 89.56% 89.67% +0.10%
==========================================
Files 171 174 +3
Lines 3202 3244 +42
Branches 544 549 +5
==========================================
+ Hits 2868 2909 +41
Misses 198 198
- Partials 136 137 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Cool, thanks for taking #1629 over the finish line. I was having issue with the AST query syntax to get single element arrays right, and my tests did not yet pass. |
@JamesHenry Is there anything else that's needed in this PR? |
@reduckted @csvn Thanks a lot for your work on this I'm very sorry for the delay in getting it in. The only tweak I made was to the rule description as I felt it was tied too strongly to an earlier iteration of the rule proposal |
Building on the work of @csvn from #1629 (❤️), this PR applies the suggestions and fixes a couple of bugs by:
consistent-component-styles
'string'
) or always use an array even if it has one element ('array'
).