Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introspection or trace for warning "Action timed out" #45

Open
adverley opened this issue Apr 14, 2023 · 2 comments
Open

Introspection or trace for warning "Action timed out" #45

adverley opened this issue Apr 14, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@adverley
Copy link
Contributor

The current implementation warns users if actions timed out which is really useful. It might be handy to know the source of the timed-out action.

@tlpss
Copy link
Contributor

tlpss commented Apr 18, 2023

Agreed. Errors (instead of warnings) would do this but I thought it would not always be desirable to raise an error.
If we believe errrors are fine, we get the trace for free. If not we can use inspect to print the stack. https://stackoverflow.com/questions/1156023/print-current-call-stack-from-a-method-in-code

@adverley what do you think? should we raise errors or warnings?

@adverley
Copy link
Contributor Author

It doesn't feel right to crash other people their application because they had a timed-out action. I'm in favor of keeping the warning and printing part of the stack with inspect.

@adverley adverley added the enhancement New feature or request label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants