Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message to be more helpful #33

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Fix error message to be more helpful #33

merged 4 commits into from
Aug 23, 2023

Conversation

dicko2
Copy link
Contributor

@dicko2 dicko2 commented Aug 23, 2023

image

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15% ⚠️

Comparison is base (aab7db6) 82.33% compared to head (4fed025) 82.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   82.33%   82.18%   -0.15%     
==========================================
  Files          27       27              
  Lines        1098     1100       +2     
==========================================
  Hits          904      904              
- Misses        194      196       +2     
Files Changed Coverage Δ
src/Agoda.IoC.Core/RegistrationFailedException.cs 37.50% <0.00%> (-12.50%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dicko2
Copy link
Contributor Author

dicko2 commented Aug 23, 2023

image

@kchinburarat
Copy link
Contributor

@dicko2 Please help to check codecov job :)

Copy link
Contributor

@kchinburarat kchinburarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

@dicko2
Copy link
Contributor Author

dicko2 commented Aug 23, 2023

I think codecov broken. I checked it vs my Ide. The lines it says I'm missing are marked as covered in my Ide

@dicko2 dicko2 merged commit 44e083e into main Aug 23, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants