Fix error message to be more helpful (#33)

* Fix error emssage to be more helpful

* add some tests

* remove unused code

* add some more assertions

src/Agoda.IoC.Core/RegistrationFailedException.cs

@@ -1,19 +1,24 @@
 using System;
+using System.Collections.Generic;
 using System.Runtime.Serialization;
 
 namespace Agoda.IoC.Core
 {
  [Serializable]
  public class RegistrationFailedException : Exception
  {
+ private readonly List<RegistrationContextException> _registrationContextExceptions;
+
+ public List<RegistrationContextException> RegistrationContextExceptions => _registrationContextExceptions;
+
  public RegistrationFailedException(string message)
  : base(message)
  {
  }
-
- private RegistrationFailedException(SerializationInfo info, StreamingContext context)
- : base(info, context)
+ public RegistrationFailedException(string message, List<RegistrationContextException> errors)
+ : base(message)
  {
+ _registrationContextExceptions = errors;
  }
  }
 }

src/Agoda.IoC.NetCore.UnitTests/MicrosoftExtensionsDependencyInjectionAutowireInvalidTests.cs

@@ -1,7 +1,9 @@
-using Agoda.IoC.Core;
+using System;
+using Agoda.IoC.Core;
 using Agoda.IoC.ProjectUnderTest.Invalid12;
 using Microsoft.Extensions.DependencyInjection;
 using NUnit.Framework;
+using Shouldly;
 
 namespace Agoda.IoC.NetCore.UnitTests
 {
@@ -19,6 +21,20 @@ public void RegisterByAttribute_WithAmbiguousRegistration_Throws()
  {
  options.OnRegistrationContextException = exception => { };
  }));
+ try
+ {
+ container.AutoWireAssembly(new[]
+ {
+ typeof(AmbiguousRegistration).Assembly
+ }, false);
+ }
+ catch (RegistrationFailedException registrationFailedException)
+ {
+ registrationFailedException.RegistrationContextExceptions.Count.ShouldBe(1);
+ registrationFailedException.RegistrationContextExceptions[0].Message.ShouldContain("AmbiguousRegistration");
+ registrationFailedException.RegistrationContextExceptions[0].RegistrationContext.ShouldNotBeNull();
+ registrationFailedException.RegistrationContextExceptions[0].RegistrationContext.Validation.IsValid.ShouldBeFalse();
+ }
  }
  }
 }

src/Agoda.IoC.NetCore/StartupExtension.cs

@@ -50,9 +50,9 @@ public static IServiceCollection AutoWireAssembly<T>(
  ))
  .ToList();
 
- if (!Validate(registrations, containerRegistrationOption))
+ if (!Validate(registrations, containerRegistrationOption, out var errors))
  {
- throw new RegistrationFailedException("There are validations error!!!");
+ throw new RegistrationFailedException("There are validations errors, please see RegistrationContextExceptions Property for details", errors);
  }
 
  foreach (var reg in registrations)
@@ -151,19 +151,19 @@ private static void RegisterKeyedFactory(this IServiceCollection services, IDict
  }
  }
 
- private static bool Validate(List<RegistrationContext> registrations, ContainerRegistrationOption containerRegistrationOption)
+ private static bool Validate(List<RegistrationContext> registrations, ContainerRegistrationOption containerRegistrationOption, out List<RegistrationContextException> errors)
  {
- bool isValid = true;
- registrations.ForEach(reg =>
+ var isValid = true;
+ errors = new List<RegistrationContextException>();
+ foreach (var registration in registrations.Where(registration => !registration.Validation.IsValid))
  {
- if (!reg.Validation.IsValid)
- {
- isValid = false;
- containerRegistrationOption
- .OnRegistrationContextException?
- .Invoke(new RegistrationContextException(reg, reg.Validation.ErrorMessage));
- }
- });
+ isValid = false;
+ var exception = new RegistrationContextException(registration, registration.Validation.ErrorMessage);
+ errors.Add(exception);
+ containerRegistrationOption
+ .OnRegistrationContextException?
+ .Invoke(exception);
+ }
  return isValid;
  }
  }