[WIP] [Redux Toolkit Migration] accountSlice #4012
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
/update-vrt |
joel-jeremy
force-pushed
the
redux-toolkit
branch
from
5b062e2 to
dd92cb3
Compare
joel-jeremy
force-pushed
the
redux-toolkit-createSlice
branch
from
9f560a7 to
ed63667
Compare
This was referenced Dec 20, 2024
joel-jeremy
commented
Dec 20, 2024
| @@ -289,7 +300,8 @@ type AccountInternalProps = { | |||
| categoryGroups: ReturnType<typeof useCategories>['grouped']; | |||
| hideFraction: boolean; | |||
| accountsSyncing: string[]; | |||
| } & ReturnType<typeof useActions>; | |||
There was a problem hiding this comment.
Remove the useActions prop here. Instead we will pass in the dispatch function and dispatch the actions manually instead.
|
|
||
| export function listenForSyncEvent(actions, store) { |
There was a problem hiding this comment.
Remove actions from useActions here. Instead, we manually dispatch the actions through the store's dispatch property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/account.ts/reducers/account.ts->accounts/accountsSlice.ts[WIP] [Redux Toolkit Migration] accountSlice #4012actions/queries.ts/reducers/queries.ts->queries/queriesSlice.tsactions/app.ts/reducers/app.ts->app/appSlice.tsactions/budgets.ts/reducers/budgets.ts->budgets/budgetsSlice.tsactions/modals.ts/reducers/modals.ts->modals/modalsSlice.tsactions/notifications.ts/reducers/notifications.ts->notifications/notificationsSlice.tsactions/prefs.ts/reducers/prefs.ts->prefs/prefsSlice.tsactions/user.ts/reducers/user.ts->users/usersSlice.ts