Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Redux Toolkit Migration] appSlice #4018

Open
wants to merge 3 commits into
base: redux-toolkit-queries-slice
Choose a base branch
from

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Dec 20, 2024

@actual-github-bot actual-github-bot bot changed the title [Redux Toolkit Migration] appSlice [WIP] [Redux Toolkit Migration] appSlice Dec 20, 2024
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 6f3980f
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/67659e7cc4ae3100086a85ad
😎 Deploy Preview https://deploy-preview-4018.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joel-jeremy joel-jeremy changed the base branch from master to redux-toolkit-queries-slice December 20, 2024 16:42
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 5.57 MB → 5.57 MB (-27 B) -0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/client/app/appSlice.ts 🆕 +784 B 0 B → 784 B
src/components/HelpMenu.tsx 📈 +719 B (+30.78%) 2.28 kB → 2.98 kB
src/index.tsx 📈 +91 B (+11.70%) 778 B → 869 B
home/runner/work/actual/actual/packages/loot-core/src/client/store/index.ts 📈 +28 B (+2.67%) 1.03 kB → 1.05 kB
src/browser-preload.browser.js 📈 +43 B (+0.97%) 4.33 kB → 4.37 kB
home/runner/work/actual/actual/packages/loot-core/src/platform/client/undo/index.web.ts 📈 +2 B (+0.27%) 741 B → 743 B
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/modals.ts 📈 +3 B (+0.23%) 1.28 kB → 1.28 kB
src/util/versions.ts 📈 +2 B (+0.19%) 1.01 kB → 1.01 kB
src/gocardless.ts 📈 +1 B (+0.10%) 964 B → 965 B
home/runner/work/actual/actual/packages/loot-core/src/platform/client/fetch/index.browser.ts 📈 +2 B (+0.06%) 3.36 kB → 3.36 kB
src/components/settings/Export.tsx 📈 +1 B (+0.04%) 2.22 kB → 2.23 kB
src/components/UpdateNotification.tsx 📈 +1 B (+0.03%) 3.59 kB → 3.59 kB
src/components/modals/manager/ImportYNAB5Modal.tsx 📈 +1 B (+0.02%) 3.98 kB → 3.98 kB
src/components/modals/manager/ImportYNAB4Modal.tsx 📈 +1 B (+0.02%) 3.98 kB → 3.98 kB
src/components/modals/manager/ImportActualModal.tsx 📈 +1 B (+0.02%) 4.38 kB → 4.38 kB
src/components/modals/manager/FilesSettingsModal.tsx 📈 +1 B (+0.02%) 6.01 kB → 6.01 kB
src/components/manager/ManagementApp.tsx 📈 +1 B (+0.02%) 6.09 kB → 6.09 kB
src/components/settings/index.tsx 📈 +1 B (+0.02%) 6.28 kB → 6.28 kB
src/components/FatalError.tsx 📈 +1 B (+0.01%) 8.13 kB → 8.13 kB
src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx 📈 +1 B (+0.00%) 30.14 kB → 30.14 kB
src/components/accounts/Account.tsx 📉 -2 B (-0.00%) 44.71 kB → 44.71 kB
node_modules/react-dom/cjs/react-dom.production.min.js 📉 -6 B (-0.00%) 130.02 kB → 130.01 kB
src/components/reports/Overview.tsx 📉 -2 B (-0.01%) 14.79 kB → 14.79 kB
src/global-events.ts 📉 -3 B (-0.09%) 3.2 kB → 3.19 kB
src/components/manager/ConfigServer.tsx 📉 -8 B (-0.11%) 7.24 kB → 7.23 kB
src/components/modals/manager/ConfirmChangeDocumentDir.tsx 📉 -20 B (-0.29%) 6.84 kB → 6.82 kB
home/runner/work/actual/actual/packages/loot-core/src/client/constants.ts 📉 -39 B (-5.05%) 772 B → 733 B
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/index.ts 📉 -17 B (-11.97%) 142 B → 125 B
home/runner/work/actual/actual/packages/loot-core/src/client/actions/app.ts 🔥 -1.26 kB (-100%) 1.26 kB → 0 B
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/app.ts 🔥 -320 B (-100%) 320 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 3.49 MB → 3.49 MB (-23 B) -0.00%
static/js/wide.js 161.57 kB → 161.57 kB (-2 B) -0.00%
static/js/ReportRouter.js 1.58 MB → 1.58 MB (-2 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/useAccountPreviewTransactions.js 1.63 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/narrow.js 83.76 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/TransactionList.js 102.79 kB 0%

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.32 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.32 MB 0%

@joel-jeremy joel-jeremy force-pushed the redux-toolkit-queries-slice branch from 2680a69 to 373fa93 Compare December 20, 2024 16:58
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from 3aebb01 to 643b197 Compare December 20, 2024 17:00
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-queries-slice branch from 373fa93 to a18db77 Compare December 20, 2024 17:29
@joel-jeremy joel-jeremy force-pushed the redux-toolkit-app-slice branch from b2d173b to 2d96d05 Compare December 20, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant