fix select2 problem with taxonomy scraper

[kraftner]

fixes #26

[herregroen]

This unfortunately doesn't fix the issue for ACF5.

It seems to be a timing issue, when the Taxonomy scraper instantiates the select2 field hasn't yet been created. This due to it being created earlier when the ReplaceVars instantiate.

Delaying the replaceVars.createReplaceVars function until the ACF ready event resolves the issue.

See the code below:

acf.add_action('ready', function () {
	_self.replaceVars = replaceVars.createReplaceVars(collect);
});

[kraftner]

Okay, that it is a timing issue might explain why I didn't see the problem. 😕

I've just pushed another commit, can you try if that fixes it for you?

[herregroen]

Can confirm that all related tests pass as expected and manually testing everything looks good.

I am getting a failure on the Gallery test due to it not opening on the Media Library tab but I'll create a separate issue and pull request for that.

I'll merge this one and I think #43 should then be rebased on features/acf-5 so the ACF5 tests can be run ( and should pass ).