Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly incomplete fix for select2 issue #79

Closed
kraftner opened this issue Sep 20, 2017 · 0 comments · Fixed by #105
Closed

Possibly incomplete fix for select2 issue #79

kraftner opened this issue Sep 20, 2017 · 0 comments · Fixed by #105
Milestone

Comments

@kraftner
Copy link
Contributor

I just realised that the fix for #26 we introduced with #45 is incomplete as things can possibly still fail as people can opt to stick with select2 v3 even with ACF5.6+.

add_filter('acf/settings/select2_version', function(){ return 3; });

See https://www.advancedcustomfields.com/blog/acf-pro-5-6-0-ui-ux/ and https://www.advancedcustomfields.com/resources/acf-settings/ for more Details.

So instead of deciding based on the ACF version we'll probably need to determine what is actually enqueued on the page with acf_get_setting('select2_version'), expose this client side as part of the JS config and decide upon this data on how to scrape inside the taxonomy scraper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants