Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenVault: Implementing full EIP-20 support #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Mar 22, 2019

  1. TokenVault: Implementing full EIP-20 support

    Previously we had a check for isToken() interface function.
    The check was important to test if the address is actually a token, wrong token
    would make claiming upon unsuccesful locking impossible.
    
    However, isToken() is not part of the official EIP-20 token specification,
    making this particular implementation of the TokenVault TokenMarket specific.
    
    TokenVault should support all EIP-20 tokens, including our SecurityToken.
    
    The check is not needed anymore, since we inherit Recoverable, which enables
    us to claim any tokens which are not locked. Hence, removing the check.
    villesundell committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    e57ad4a View commit details
    Browse the repository at this point in the history