TokenVault: Implementing full EIP-20 support #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a check for isToken() interface function.
The check was important to test if the address is actually a token, wrong token
would make claiming upon unsuccesful locking impossible.
However, isToken() is not part of the official EIP-20 token specification,
making this particular implementation of the TokenVault TokenMarket specific.
TokenVault should support all EIP-20 tokens, including our SecurityToken.
The check is not needed anymore, since we inherit Recoverable, which enables
us to claim any tokens which are not locked. Hence, removing the check.