Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate video description and about channel fragments to Jetpack Compose #11489

Open
wants to merge 17 commits into
base: refactor
Choose a base branch
from
Open

Migrate video description and about channel fragments to Jetpack Compose #11489

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
99996d9
Rename .java to .kt
Isira-Seneviratne Aug 27, 2024
de6285b
Migrate description fragment to Jetpack Compose
Isira-Seneviratne Aug 27, 2024
2653787
Migrate about channel fragment to Jetpack Compose
Isira-Seneviratne Sep 1, 2024
507b3b4
Show image tags even if image loading is disabled
Isira-Seneviratne Sep 1, 2024
45aa445
Fix crash when minimizing the channel about tab
Isira-Seneviratne Sep 1, 2024
a094abd
Use constant
Isira-Seneviratne Sep 1, 2024
bbbb7f5
Use textAlign in TagsSection
Isira-Seneviratne Sep 1, 2024
387a4d5
Rm unused layouts
Isira-Seneviratne Sep 1, 2024
bc87575
Allow scrolling of about channel section
Isira-Seneviratne Sep 2, 2024
c4efd2f
Update dependencies
Isira-Seneviratne Sep 2, 2024
31d164d
Update dependencies
Isira-Seneviratne Sep 5, 2024
8f9faf3
Address some review comments
Isira-Seneviratne Sep 6, 2024
0d12cfc
Remove AndroidX Browser, make scrollbars red
Isira-Seneviratne Sep 6, 2024
1f4298b
Avoid issues if context is a ContextWrapper
Isira-Seneviratne Sep 11, 2024
cd96927
Merge branch 'refactor' into Video-description-compose
Isira-Seneviratne Nov 21, 2024
a69c48a
Reuse LazyColumnThemedScrollbar
Isira-Seneviratne Nov 21, 2024
d000840
Merge branch 'refactor' into Video-description-compose
Isira-Seneviratne Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ dependencies {
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
implementation 'androidx.core:core-ktx:1.12.0'
implementation 'androidx.documentfile:documentfile:1.0.1'
implementation 'androidx.fragment:fragment-ktx:1.6.2'
implementation 'androidx.fragment:fragment-compose:1.8.2'
implementation "androidx.lifecycle:lifecycle-livedata-ktx:${androidxLifecycleVersion}"
implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:${androidxLifecycleVersion}"
implementation 'androidx.localbroadcastmanager:localbroadcastmanager:1.1.0'
Expand Down Expand Up @@ -286,12 +286,11 @@ dependencies {
implementation "org.ocpsoft.prettytime:prettytime:5.0.8.Final"

// Jetpack Compose
implementation(platform('androidx.compose:compose-bom:2024.06.00'))
implementation 'androidx.compose.material3:material3:1.3.0-beta05'
implementation 'androidx.compose.material3.adaptive:adaptive:1.0.0-beta04'
implementation(platform('androidx.compose:compose-bom:2024.09.00'))
implementation 'androidx.compose.material3:material3'
implementation 'androidx.compose.material3.adaptive:adaptive'
implementation 'androidx.activity:activity-compose'
implementation 'androidx.compose.ui:ui-tooling-preview'
implementation 'androidx.compose.ui:ui-text:1.7.0-beta07' // Needed for parsing HTML to AnnotatedString
implementation 'androidx.lifecycle:lifecycle-viewmodel-compose'
implementation 'androidx.paging:paging-compose:3.3.2'
implementation 'com.github.nanihadesuka:LazyColumnScrollbar:2.2.0'
Expand Down
281 changes: 0 additions & 281 deletions app/src/main/java/org/schabi/newpipe/fragments/detail/BaseDescriptionFragment.java
View file
Open in desktop

This file was deleted.

Loading
Loading